All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre <pinaraf@pinaraf.info>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] Fix NULL pointer deref. on no default_rng
Date: Thu, 07 Dec 2017 11:32:47 +0100	[thread overview]
Message-ID: <2556930.8tHcIEql08@peanuts2> (raw)
In-Reply-To: <20171129063430.GD21575@gondor.apana.org.au>

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

On Wednesday, November 29, 2017 5:34:30 PM CET you wrote:
> On Sun, Nov 12, 2017 at 03:24:32PM +0100, Pierre Ducroquet wrote:
> > If crypto_get_default_rng returns an error, the
> > function ecc_gen_privkey should return an error.
> > Instead, it currently tries to use the default_rng
> > nevertheless, thus creating a kernel panic with a
> > NULL pointer dereference.
> > Returning the error directly, as was supposedly
> > intended when looking at the code, fixes this.
> > 
> > Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
> 
> Patch applied.  Thanks.

Thanks to you.

Will it be backported to 4.14 and the LTS releases ? Currently, no recent 
debian kernel can boot on my system without that patch (I don't know why 
nobody else noticed that before).

 Pierre

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-12-07 10:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-12 14:24 [PATCH] Fix NULL pointer deref. on no default_rng Pierre Ducroquet
2017-11-12 14:46 ` PrasannaKumar Muralidharan
2017-11-18 17:18   ` Pierre
2017-11-29  6:34 ` Herbert Xu
2017-12-07 10:32   ` Pierre [this message]
2017-12-20 19:49   ` Pierre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2556930.8tHcIEql08@peanuts2 \
    --to=pinaraf@pinaraf.info \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.