From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88E9FA3743 for ; Mon, 31 Oct 2022 15:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231765AbiJaPMt (ORCPT ); Mon, 31 Oct 2022 11:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231744AbiJaPMq (ORCPT ); Mon, 31 Oct 2022 11:12:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587431114D for ; Mon, 31 Oct 2022 08:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667229105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3i4O1OOlu+3cslGOPuuct7EW6mOAN9LMnhUF+hNbZg0=; b=Rg3hdtURzHHVhRNGI6SXWo6F/IQoVPktrH6SYjmdhFCwHEd0McSmZG3g7s3LPF1KlRa8D2 oOFEDmlBc0vu/UyFZDK5CJ2KQiamDZJvcp1ElSwD40lmlpZKgMWFqKJxwfIY7oiVG4I38b vESwJaBD5vtkOFhojyutaIV3t74VMNo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-lN4A6MP6PUuHc3ZDlu-yIg-1; Mon, 31 Oct 2022 11:11:41 -0400 X-MC-Unique: lN4A6MP6PUuHc3ZDlu-yIg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76FDA101A528; Mon, 31 Oct 2022 15:11:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46119C15BA4; Mon, 31 Oct 2022 15:11:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221028151526.319681-2-willy@infradead.org> References: <20221028151526.319681-2-willy@infradead.org> <20221028151526.319681-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-mm@kvack.org, Uladzislau Rezki , Dave Chinner , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Ira Weiny , "Fabio M. De Francesco" , Luis Chamberlain Subject: Re: [PATCH 1/1] mm: Add folio_map_local() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2557441.1667229098.1@warthog.procyon.org.uk> Date: Mon, 31 Oct 2022 15:11:38 +0000 Message-ID: <2557442.1667229098@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > +static inline __must_check void *folio_map_local(struct folio *folio) > +{ > + might_alloc(GFP_KERNEL); > + > + if (!IS_ENABLED(CONFIG_HIGHMEM)) > + return folio_address(folio); Can you make the might_alloc() contingent on CONFIG_HIGHMEM=y? David