From: Thomas Monjalon <thomas@monjalon.net>
To: Fady Bader <fady@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"talshn@mellanox.com" <talshn@mellanox.com>,
"yohadt@mellanox.com" <yohadt@mellanox.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"harini.ramakrishnan@microsoft.com"
<harini.ramakrishnan@microsoft.com>,
"ocardona@microsoft.com" <ocardona@microsoft.com>,
"anand.rawat@intel.com" <anand.rawat@intel.com>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] ring: build on Windows
Date: Thu, 21 May 2020 10:26:17 +0200 [thread overview]
Message-ID: <2557491.TtRDRv7A1Z@thomas> (raw)
In-Reply-To: <DBBPR08MB4646EEC7E844FE628EA8874C98B70@DBBPR08MB4646.eurprd08.prod.outlook.com>
21/05/2020 06:17, Honnappa Nagarahalli:
> <snip>
>
> > Subject: [dpdk-dev] [PATCH v2] ring: build on Window
> ^^^^ change this to 'eal'.
>
> Even though the compilation error points to rte_ring, this is not a issue in rte_ring library. Suggest changing the commit message to something like "eal: add per_lcore__rte_errno to export list for Windows".
The dedicated title prefix is "eal/windows:"
> > Exported per_lcore__rte_errno function to compile ring for windows.
> >
> > compilation error logs:
> > librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol
> > per_lcore__rte_errno referenced in function rte_ring_lookup
> >
> > The cause was that per_lcore__rte_errno function wasn't included in the
> > export list.
> > To solve this per_lcore__rte_errno was added to the Windows export list.
> >
> > Signed-off-by: Fady Bader <fady@mellanox.com>
> > Depends-on: series-9374 ("Windows basic memory management")
> > ---
The "Depends-on" line is not supposed to be part of the merged commit.
The trick is to insert "---" line on top of such annotation,
so it will be automatically skipped when applying the patch with "git am".
We use the same trick for changelogs.
Reminder: a v2 patch should include a changelog and be sent with these options:
-v2 --annotate --in-reply-to 'MESSAGE-ID-OF-v1'
next prev parent reply other threads:[~2020-05-21 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 10:44 [dpdk-dev] [PATCH v2] ring: build on Windows Fady Bader
2020-05-20 20:46 ` Ranjit Menon
2020-05-21 4:17 ` Honnappa Nagarahalli
2020-05-21 8:26 ` Thomas Monjalon [this message]
2020-05-21 15:02 ` Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2557491.TtRDRv7A1Z@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=anand.rawat@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=nd@arm.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.