From: Arnd Bergmann <arnd@arndb.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>
Cc: linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Subject: Re: [PATCH] [SCSI] bfa: Remove use of struct timeval
Date: Wed, 04 Feb 2015 16:07:53 +0100 [thread overview]
Message-ID: <2559983.ap4ZrMWJg3@wuerfel> (raw)
In-Reply-To: <20150204031203.GA3762@tinar>
On Wednesday 04 February 2015 08:42:03 Tina Ruchandani wrote:
> struct timeval will have its tv_sec field overflow on 32-bit systems
> in year 2038 and beyond. This patch removes the usage of struct timeval
> and instead uses ktime_get_real_seconds() which returns 64-bit wall-clock
> seconds.
>
> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
>
The patch is correct, but you can do it better by removing the
bfa_get_log_time() function completely and changing the
four callers to call ktime_get_real_seconds() directly.
The subject line could be improved too: you don't remember all uses
of timeval in this patch, but only one of them. When you do the
first change, a good subject line would be:
[SCSI] bfa: replace bfa_get_log_time with ktime_get_real_seconds
Arnd
prev parent reply other threads:[~2015-02-04 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 3:12 [PATCH] [SCSI] bfa: Remove use of struct timeval Tina Ruchandani
2015-02-04 15:07 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2559983.ap4ZrMWJg3@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@parallels.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
--cc=sudarsana.kalluru@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.