Re: [niks:has_ioport_v4 36/41] drivers/usb/host/xhci-hub.c:1805:37: error: implicit declaration of function 'usb_amd_pt_check_port'

[Niklas Schnelle <schnelle@linux.ibm.com>]

On Thu, 2023-05-11 at 20:41 +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/niks/linux.git has_ioport_v4
> head:   7591a40aebcc68208650e4324799df61bed47bb4
> commit: 96ffabef0a84bae16aff7e26ac08322a27358e1b [36/41] usb: pci-quirks: handle HAS_IOPORT dependencies
> config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20230511/202305112044.901Gb35D-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/niks/linux.git/commit/?id=96ffabef0a84bae16aff7e26ac08322a27358e1b
>         git remote add niks https://git.kernel.org/pub/scm/linux/kernel/git/niks/linux.git
>         git fetch --no-tags niks has_ioport_v4
>         git checkout 96ffabef0a84bae16aff7e26ac08322a27358e1b
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/usb/host/
> 
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202305112044.901Gb35D-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/usb/host/xhci-hub.c: In function 'xhci_bus_suspend':
> > > drivers/usb/host/xhci-hub.c:1805:37: error: implicit declaration of function 'usb_amd_pt_check_port' [-Werror=implicit-function-declaration]
>     1805 |                                 if (usb_amd_pt_check_port(hcd->self.controller,
>          |                                     ^~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 

Ok, since I obviously forgot another declaration in pci-quirks.h I now
checked all of the non-static functions conditional on
CONFIG_USB_PCI_AMD manually. With my current state plus the above fixed
all except for usb_hcd_amd_remote_wakeup_quirk() have a prototype and a
stub in pci-quirks.h. So I'm thinking if I provide a stub for
usb_hcd_amd_remote_wakeup_quirk() that just returns 0 I can get rid of
the #ifdef CONFIG_USB_PCI_AMD in hcd-pci.c and have all of them easily
checkable. So did that.

Thanks,
Niklas