From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:41393 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933063AbcLTBHi (ORCPT ); Mon, 19 Dec 2016 20:07:38 -0500 From: Laurent Pinchart To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] gpu: drm: rcar-du: rcar_du_drv: don't open code of_device_get_match_data() Date: Tue, 20 Dec 2016 03:08:05 +0200 Message-ID: <2560269.bN5qXdpXVS@avalon> In-Reply-To: <1456850269-8290-1-git-send-email-wsa@the-dreams.de> References: <1456850269-8290-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Wolfram, Thank you for the patch. It looks like I've missed it, sorry about that. On Tuesday 01 March 2016 17:37:34 Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code and make it more readable. > > Signed-off-by: Wolfram Sang Acked-by: Laurent Pinchart Tested-by: Laurent Pinchart and taken in my tree. > --- > > Compile tested only. I am on the road and can't test the multimedia drivers > because of no cables :( If someone could test it, that would be much > appreciated. Or I'll do it next week. The pattern worked for other drivers > I could actually test, though. > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index > ed6006bf6bd893..ac95509e80bb7c 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -318,7 +318,7 @@ static int rcar_du_probe(struct platform_device *pdev) > init_waitqueue_head(&rcdu->commit.wait); > > rcdu->dev = &pdev->dev; > - rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data; > + rcdu->info = of_device_get_match_data(rcdu->dev); > > ddev = drm_dev_alloc(&rcar_du_driver, &pdev->dev); > if (!ddev) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] gpu: drm: rcar-du: rcar_du_drv: don't open code of_device_get_match_data() Date: Tue, 20 Dec 2016 03:08:05 +0200 Message-ID: <2560269.bN5qXdpXVS@avalon> References: <1456850269-8290-1-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id D536B6E22B for ; Tue, 20 Dec 2016 01:07:36 +0000 (UTC) In-Reply-To: <1456850269-8290-1-git-send-email-wsa@the-dreams.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgV29sZnJhbSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLiBJdCBsb29rcyBsaWtlIEkndmUg bWlzc2VkIGl0LCBzb3JyeSBhYm91dCB0aGF0LgoKT24gVHVlc2RheSAwMSBNYXJjaCAyMDE2IDE3 OjM3OjM0IFdvbGZyYW0gU2FuZyB3cm90ZToKPiBGcm9tOiBXb2xmcmFtIFNhbmcgPHdzYStyZW5l c2FzQHNhbmctZW5naW5lZXJpbmcuY29tPgo+IAo+IFRoaXMgY2hhbmdlIHdpbGwgYWxzbyBtYWtl IENvdmVyaXR5IGhhcHB5IGJ5IGF2b2lkaW5nIGEgdGhlb3JldGljYWwgTlVMTAo+IHBvaW50ZXIg ZGVyZWZlcmVuY2U7IHlldCBhbm90aGVyIHJlYXNvbiBpcyB0byB1c2UgdGhlIGFib3ZlIGhlbHBl ciBmdW5jdGlvbgo+IHRvIHRpZ2h0ZW4gdGhlIGNvZGUgYW5kIG1ha2UgaXQgbW9yZSByZWFkYWJs ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBXb2xmcmFtIFNhbmcgPHdzYStyZW5lc2FzQHNhbmctZW5n aW5lZXJpbmcuY29tPgoKQWNrZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbT4KVGVzdGVkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CgphbmQgdGFrZW4gaW4gbXkgdHJlZS4KCj4gLS0t Cj4gCj4gQ29tcGlsZSB0ZXN0ZWQgb25seS4gSSBhbSBvbiB0aGUgcm9hZCBhbmQgY2FuJ3QgdGVz dCB0aGUgbXVsdGltZWRpYSBkcml2ZXJzCj4gYmVjYXVzZSBvZiBubyBjYWJsZXMgOiggSWYgc29t ZW9uZSBjb3VsZCB0ZXN0IGl0LCB0aGF0IHdvdWxkIGJlIG11Y2gKPiBhcHByZWNpYXRlZC4gT3Ig SSdsbCBkbyBpdCBuZXh0IHdlZWsuIFRoZSBwYXR0ZXJuIHdvcmtlZCBmb3Igb3RoZXIgZHJpdmVy cwo+IEkgY291bGQgYWN0dWFsbHkgdGVzdCwgdGhvdWdoLgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X2Rydi5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9k cnYuYyBpbmRleAo+IGVkNjAwNmJmNmJkODkzLi5hYzk1NTA5ZTgwYmI3YyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+IEBAIC0zMTgsNyArMzE4LDcgQEAgc3RhdGlj IGludCByY2FyX2R1X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlpbml0 X3dhaXRxdWV1ZV9oZWFkKCZyY2R1LT5jb21taXQud2FpdCk7Cj4gCj4gIAlyY2R1LT5kZXYgPSAm cGRldi0+ZGV2Owo+IC0JcmNkdS0+aW5mbyA9IG9mX21hdGNoX2RldmljZShyY2FyX2R1X29mX3Rh YmxlLCByY2R1LT5kZXYpLT5kYXRhOwo+ICsJcmNkdS0+aW5mbyA9IG9mX2RldmljZV9nZXRfbWF0 Y2hfZGF0YShyY2R1LT5kZXYpOwo+IAo+ICAJZGRldiA9IGRybV9kZXZfYWxsb2MoJnJjYXJfZHVf ZHJpdmVyLCAmcGRldi0+ZGV2KTsKPiAgCWlmICghZGRldikKCi0tIApSZWdhcmRzLAoKTGF1cmVu dCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK