From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Jon Hunter <jonathanh@nvidia.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 2/2] gpio: rcar: Fine-grained Runtime PM support
Date: Fri, 09 Dec 2016 01:21:27 +0200 [thread overview]
Message-ID: <2561777.Aed1u6m3Fd@avalon> (raw)
In-Reply-To: <20161208231551.GL21834@bigcity.dyn.berto.se>
Hi Niklas,
On Friday 09 Dec 2016 00:15:51 Niklas Söderlund wrote:
> On 2016-12-08 23:40:42 +0200, Laurent Pinchart wrote:
> > On Thursday 08 Dec 2016 18:32:28 Niklas Söderlund wrote:
> >> From: Geert Uytterhoeven <geert+renesas@glider.be>
> >>
> >> Currently gpio modules are runtime-resumed at probe time. This means the
> >> gpio module will be active all the time (except during system suspend,
> >> if not configured as a wake-up source).
> >>
> >> While an R-Car Gen2 gpio module retains pins configured for output at
> >> the requested level while put in standby mode, gpio register cannot be
> >> accessed while suspended. Unfortunately pm_runtime_get_sync() cannot be
> >> called from all contexts where gpio register access is needed. Hence
> >> move the Runtime PM handling from probe/remove time to gpio request/free
> >> time, which is probably the best we can do.
> >>
> >> On r8a7791/koelsch, gpio modules 0, 1, 3, and 4 are now suspended during
> >> normal use (gpio2 is used for LEDs and regulators, gpio5 for keys, gpio6
> >> for SD-Card CD & WP, gpio7 for keys and regulators).
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> [Niklas: s/gpio_to_priv(chip)/gpiochip_get_data(chip)/]
> >
> > Just curious, what's the rationale for this ?
>
> This was changed for the whole driver after the original patch was
> applied (at the time of change the patch was not yet reverted), see [1].
> I needed to update this when I resurrected the patch, maybe I could have
> been more clever and reverted the revert patch but this felt cleaner, if
> it's better to do it the other way around and revert a revert please let
> me know so I can do so in the future.
No, this is fine. I'm a bit dubious about [1] given that it consumes more CPU
cycles without any benefit as far as I can see. Maybe I can't see far enough
though, Linus Walleij could prove me wrong :-)
> [1] c7b6f457cb53bcee ("gpio: rcar: use gpiochip data pointer").
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-12-08 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 17:32 [PATCH 0/2] gpio: rcar: (re)add Runtime PM support Niklas Söderlund
2016-12-08 17:32 ` [PATCH 1/2] gpio: rcar: set IRQ chip parent_device Niklas Söderlund
2016-12-08 21:36 ` Laurent Pinchart
2016-12-09 10:43 ` Geert Uytterhoeven
2016-12-28 0:31 ` Linus Walleij
2016-12-08 17:32 ` [PATCH 2/2] gpio: rcar: Fine-grained Runtime PM support Niklas Söderlund
2016-12-08 21:40 ` Laurent Pinchart
2016-12-08 23:15 ` Niklas Söderlund
2016-12-08 23:15 ` Niklas Söderlund
2016-12-08 23:21 ` Laurent Pinchart [this message]
2016-12-15 23:12 ` Linus Walleij
2016-12-09 10:26 ` Geert Uytterhoeven
2016-12-28 0:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2561777.Aed1u6m3Fd@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.