From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38460CF07C7 for ; Thu, 10 Oct 2024 08:41:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.815804.1230010 (Exim 4.92) (envelope-from ) id 1syojR-0006iZ-J4; Thu, 10 Oct 2024 08:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 815804.1230010; Thu, 10 Oct 2024 08:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1syojR-0006iS-Fa; Thu, 10 Oct 2024 08:41:13 +0000 Received: by outflank-mailman (input) for mailman id 815804; Thu, 10 Oct 2024 08:41:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1syojQ-0006iM-B5 for xen-devel@lists.xenproject.org; Thu, 10 Oct 2024 08:41:12 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66410083-86e3-11ef-99a2-01e77a169b0f; Thu, 10 Oct 2024 10:41:10 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a9952ea05c5so106080066b.2 for ; Thu, 10 Oct 2024 01:41:10 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a7edea69sm56590566b.7.2024.10.10.01.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 01:41:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66410083-86e3-11ef-99a2-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1728549670; x=1729154470; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tAZ2otITJIfqunsrMLhUzakqD4tgw7FqDWbH+BmEO78=; b=FTgl51eFTU3wDqDtYyCckCjSugNxaq0yXYumncjMEveBfif1lHy13ZfZUD88xSgZQe dytXR0mHGTx2lHn2TyqMWAjlURGAbY/VSIbQF4L0Z5DmWLDAmKE+pSgDA0U+YQZpzTFO 5CiBKHRC+fLiNc6mhahH0CZMS4vaGg/3AGjYN6HFuvdYHRIwqSlBw6G2I2Vu+Ywocw9R cSiOux8IOhoF9B5hwpq/O7svwshcZ6uGFNfhqqTVGtAh1FeIz/n2iQwvSvIPXMME87Fi 8XnIrNqca1sYbrjeMPCubW8Kxu45OdQPBOoQsrnkhvZ3lk3qgqEBsYNJ1E7ENS/c/tzo uAqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728549670; x=1729154470; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tAZ2otITJIfqunsrMLhUzakqD4tgw7FqDWbH+BmEO78=; b=LAw7q47Zd1x+nLu/71O5kePvIs+wx+C4RqIYW81MW0LC+eHzZGUtTDY6ELqaiDgub3 vR+PP3K4CnUsbwRis0ooWxmwn5YsrPf/xqmDOwlAd6VcFrWHrdqL8mdmuqcfg7Akvc4S kEkmAc6NIRh3JYtrZNoEjki0NvIQhXq+On5OXjPWhgXZydQlxx5buBR0lLkkrAxGrv3C P71kzl4niEYtNuFql4aHc1Ef1e1WQwuTJ6y36uT0uEqrs/1pKmLIi9E1pp7/iVIGCAlU FP0xmpioCkcdBkJlBMrbeRGmO7avPexbWbwtUFfCdlihbWOVdHauu8M/44ejjdp477ML /WFA== X-Forwarded-Encrypted: i=1; AJvYcCUEmaQy288MM5WW73s/t/x8bxtWCkabFwfAkybOAidr94PDE9HuVxDZG1681LxJH/RLly40UFc0Bl0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxVdgVZKlVvvXXN9UuL7mbKTHLEAG6+fsxz127koXR7n0T0rLR/ K6iYE5R/bYg9w0+eDhoJu27EHS+U5y8TGnEQlRyNBo8g/M4Lz3tLwzOl9VD3xXEpEGaueJhGZRY = X-Google-Smtp-Source: AGHT+IHDLRnKeP2nK5u9BUXe6ye6orafpJzytpfu6gBIYVg2/7bkrUnYW4QouYCtAQsJlMLxovY6hA== X-Received: by 2002:a17:907:f712:b0:a99:5240:381e with SMTP id a640c23a62f3a-a998d19ef2amr470157866b.18.1728549669711; Thu, 10 Oct 2024 01:41:09 -0700 (PDT) Message-ID: <2563a637-2612-4635-9d6a-e70fd732db23@suse.com> Date: Thu, 10 Oct 2024 10:41:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/2] x86/boot: Align mbi2.c stack to 16 bytes To: Frediano Ziglio Cc: "Daniel P. Smith" , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <20241009080439.2411730-1-frediano.ziglio@cloud.com> <20241009080439.2411730-2-frediano.ziglio@cloud.com> <49d1ff38-dff7-4db0-aec8-15ca82339e54@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10.10.2024 10:34, Frediano Ziglio wrote: > On Wed, Oct 9, 2024 at 12:13 PM Jan Beulich wrote: >> >> On 09.10.2024 12:15, Frediano Ziglio wrote: >>> On Wed, Oct 9, 2024 at 9:20 AM Jan Beulich wrote: >>>> On 09.10.2024 10:04, Frediano Ziglio wrote: >>>>> --- a/xen/arch/x86/efi/Makefile >>>>> +++ b/xen/arch/x86/efi/Makefile >>>>> @@ -11,6 +11,8 @@ $(obj)/boot.init.o: $(obj)/buildid.o >>>>> $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4) >>>>> $(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS_stack_boundary := $(cflags-stack-boundary) >>>>> >>>>> +$(obj)/mbi2.o: CFLAGS_stack_boundary := $(cflags-stack-boundary) >>>>> + >>>>> obj-y := common-stub.o stub.o >>>>> obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y)) >>>>> obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y)) >>>> >>>> You're duplicating code, which is better to avoid when possible. Is there >>>> a reason the earlier commit didn't simply add mbi2.o to $(EFIOBJ-y)? That >>>> way the existing logic would have covered that file as well. And really I >>>> think it should have been mbi2.init.o (or else adding it into $(obj-bin-y) >>>> is wrong), which probably wants correcting at the same time (ISTR actually >>>> having requested that during an earlier review round). >>> >>> This was my first attempt, but it fails poorly, as EFIOBJ-y comes with >>> the addition of creating some file links that causes mbi2.c to be >>> overridden. >> >> I can't see $(EFIOBJ-y) affecting symlink creation. What I can see is that >> the variable is used in the setting of clean-files, which indeed is a problem. >> Still imo the solution then is to introduce another variable to substitute the >> uses of $(EFIOBJ-y) in arch/x86/efi/Makefile. E.g. >> >> EFIOBJ-all := $(EFIOBJ-y) mbi2.init.o >> > > what about simply > > diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile > index 7e2b5c07de..f2ce739f57 100644 > --- a/xen/arch/x86/efi/Makefile > +++ b/xen/arch/x86/efi/Makefile > @@ -9,7 +9,7 @@ $(obj)/%.o: $(src)/%.ihex FORCE > $(obj)/boot.init.o: $(obj)/buildid.o > > $(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4) > -$(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS_stack_boundary := > $(cflags-stack-boundary) > +$(addprefix $(obj)/,$(EFIOBJ-y) mbi2.o): CFLAGS_stack_boundary := > $(cflags-stack-boundary) > > obj-y := common-stub.o stub.o > obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y)) Yes, but see below for the other adjustment to make. >>> If I remember, you suggested changing to obj-bin-y. Still, maybe is >>> not the best place. It was added to obj-bin-y because it should be >>> included either if XEN_BUILD_EFI is "y" or not. >> >> No, that doesn't explain the addition to obj-bin-y; this would equally be >> achieved by adding to obj-y. The difference between the two variables is >> whether objects are to be subject to LTO. And the typical case then is that >> init-only objects aren't worth that extra build overhead. Hence the common >> pattern is (besides files with assembly sources) for *.init.o to be added to >> obj-bin-*. > > Then I would stick to obj-bin-y. Correct, yet it wants to be mbi2.init.o there. Jan