Re: [PATCH v2 3/3] eal: make memory segment preallocation OS-specific

[Thomas Monjalon <thomas@monjalon.net>]

28/06/2018 13:41, Anatoly Burakov:
> In the perfect world, it wouldn't matter how much memory was
> preallocated because most of it was always going to be private
> anonymous zero-page mappings for the duration of the program.
> However, in practice, due to peculiarities of FreeBSD, we need
> to additionally limit memory allocation there. This patch moves
> the segment preallocation to EAL private functions that will be
> implemented by an OS-specific EAL rather than being in the common
> memory-related code.
> 
> Since there is no support for growing/shrinking memory use at
> runtime on FreeBSD anyway, this does not inhibit any functionality
> but makes core dumps faster even on default settings.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> 
> Notes:
>     For Linuxapp, this is 99% code move (aside from slight changes due to
>     code deduplication between Linuxapp EAL and old common memory code),
>     while for FreeBSD it's mostly code move but with changes due to
>     dropping 32-bit code and implementing FreeBSD-specific limits on
>     memory preallocation outlined in the commit.

Applied, thanks