From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 05 Aug 2015 10:46:50 +0200 (CEST) Received: from gloria.sntech.de ([95.129.55.99]:37681 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008877AbbHEIqsg9-Pu convert rfc822-to-8bit (ORCPT ); Wed, 5 Aug 2015 10:46:48 +0200 Received: from [95.91.148.129] (helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1ZMuKJ-0007Wy-Jq; Wed, 05 Aug 2015 10:45:31 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Shawn Lin Cc: Krzysztof Kozlowski , Ulf Hansson , Jaehoon Chung , Seungwon Jeon , dianders@chromium.org, linux-mips@linux-mips.org, Arnd Bergmann , Alexandre Belloni , Alexey Brodkin , Stefan Agner , Zhou Wang , Kumar Gala , Alim Akhtar , Ian Campbell , Wang Long , Rob Herring , Chaotian Jing , Lukasz Majewski , Jun Nie , Catalin Marinas , Kevin Hao , Olof Johansson , Ray Jui , Govindraj Raja , linux-samsung-soc@vger.kernel.org, "Rafael J. Wysocki" , Geert Uytterhoeven , Vineet Gupta , Scott Branden , Anand Moon , linux-rockchip@lists.infradead.org, Tushar Behera , Pawel Moll , Will Deacon , Mischa Jonker , Ralf Baechle , Javier Martinez Canillas , Vincent Yang , Stephen Warren , devicetree@vger.kernel.org, Kukjin Kim , Tomeu Vizoso , Stephen Boyd , Russell King , Joachim Eastwood , Sjoerd Simons , Weijun Yang , Peter Griffin , linux-arm-kernel@lists.infradead.org, addy ke , Uwe Kleine-K?nig , Jean Delvare , Kevin Hilman , Andrew Bresticker , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Zhangfei Gao , Wei Xu , Andreas Faerber , Mark Rutland , Srinivas Kandagatla Subject: Re: [RFC PATCH v3 2/5] Documentation: synopsys-dw-mshc: add bindings for idmac and edmac Date: Wed, 05 Aug 2015 10:45:30 +0200 Message-ID: <2567191.z5Kn3VDlTS@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <55C1CCA8.7040304@rock-chips.com> References: <1438762614-22154-1-git-send-email-shawn.lin@rock-chips.com> <55C1C8E9.1060808@samsung.com> <55C1CCA8.7040304@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 48586 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: heiko@sntech.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Am Mittwoch, 5. August 2015, 16:43:20 schrieb Shawn Lin: > 在 2015/8/5 16:27, Krzysztof Kozlowski 写道: > > On 05.08.2015 17:17, Shawn Lin wrote: > >> synopsys-dw-mshc supports three types of transfer mode. We add bindings > >> and description for how to use them at runtime. Without idmac and edmac > >> property, pio is the default transfer mode. Make sure that Idmac and > >> emdac > >> should not be used simultaneously. > >> > >> Signed-off-by: Shawn Lin > >> --- > >> > >> Changes in v3: None > >> Changes in v2: None > >> > >> .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 41 > >> ++++++++++++++++++++++ 1 file changed, 41 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > >> b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt index > >> 346c609..30369cb 100644 > >> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > >> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > >> > >> @@ -75,6 +75,25 @@ Optional properties: > >> * vmmc-supply: The phandle to the regulator to use for vmmc. If this > >> is > >> > >> specified we'll defer probe until we can find this regulator. > >> > >> +* supports-idmac: Enables support for internal DMAC block within the > >> Synopsys + Designware Mobile Storage IP block. If supports-idmac > >> property is present, then + we MUST NOT add supports-edmac property > >> since we'd assume that dw-mshc IP is + integrated with only one type of > >> dma master. > >> + > >> +* supports-edmac: Enables support for external DMAC block outside the > >> Synopsys + Designware Mobile Storage IP block. If supports-edmac > >> property is present, then + we MUST NOT add supports-idmac property > >> since we'd assume that dw-mshc IP is + integrated with only one type of > >> dma master. > >> + > >> + (Without "supports-idmac" and "supports-edmac", use PIO as default > >> transfer mode)> > > Aren't you breaking here backward compatibility with existing DTB? > > > > Best regards, > > Krzysztof > > Thanks, Krzysztof. > I guess you mean that I should keep existing DTB w/o these two > properties work fine using idmac? yep > >> + > >> +* dmas: List of DMA specifiers with the controller specific format as > >> described + in the generic DMA client binding. This property should be > >> combined with + supports-edmac. Refer to dma.txt for details. > >> + > >> +* dma-names: DMA request names. Must be "rx-tx". And This property > >> should be + combined with supports-edmac. Refer to dma.txt for details. > >> + Similarly the use of an external dmac could simply be detected, by the presence of the dma-* properties. So when the machine defines dma channels use the external dma, otherwise the internal (or none). So you wouldn't need separate new properties at all. > >> > >> Aliases: > >> > >> - All the MSHC controller nodes should be represented in the aliases > >> node using>> > >> @@ -95,6 +114,8 @@ board specific portions as listed below. > >> > >> #size-cells = <0>; > >> > >> }; > >> > >> +[board specific internal DMA resources] > >> + > >> > >> dwmmc0@12200000 { > >> > >> clock-frequency = <400000000>; > >> clock-freq-min-max = <400000 200000000>; > >> > >> @@ -106,4 +127,24 @@ board specific portions as listed below. > >> > >> bus-width = <8>; > >> cap-mmc-highspeed; > >> cap-sd-highspeed; > >> > >> + supports-idmac; > >> > >> }; > >> > >> + > >> +[board specific generic DMA request binding] > >> + > >> + dwmmc0@12200000 { > >> + clock-frequency = <400000000>; > >> + clock-freq-min-max = <400000 200000000>; > >> + num-slots = <1>; > >> + broken-cd; > >> + fifo-depth = <0x80>; > >> + card-detect-delay = <200>; > >> + vmmc-supply = <&buck8>; > >> + bus-width = <8>; > >> + cap-mmc-highspeed; > >> + cap-sd-highspeed; > >> + supports-edmac; > >> + dmas = <&pdma 12>; > >> + dma-names = "rx-tx"; > >> + }; > >> + From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [RFC PATCH v3 2/5] Documentation: synopsys-dw-mshc: add bindings for idmac and edmac Date: Wed, 05 Aug 2015 10:45:30 +0200 Message-ID: <2567191.z5Kn3VDlTS@diego> References: <1438762614-22154-1-git-send-email-shawn.lin@rock-chips.com> <55C1C8E9.1060808@samsung.com> <55C1CCA8.7040304@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <55C1CCA8.7040304@rock-chips.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Shawn Lin Cc: Krzysztof Kozlowski , Ulf Hansson , Jaehoon Chung , Seungwon Jeon , dianders@chromium.org, linux-mips@linux-mips.org, Arnd Bergmann , Alexandre Belloni , Alexey Brodkin , Stefan Agner , Zhou Wang , Kumar Gala , Alim Akhtar , Ian Campbell , Wang Long , Rob Herring , Chaotian Jing , Lukasz Majewski , Jun Nie , Catalin Marinas List-Id: linux-mmc@vger.kernel.org Am Mittwoch, 5. August 2015, 16:43:20 schrieb Shawn Lin: > =E5=9C=A8 2015/8/5 16:27, Krzysztof Kozlowski =E5=86=99=E9=81=93: > > On 05.08.2015 17:17, Shawn Lin wrote: > >> synopsys-dw-mshc supports three types of transfer mode. We add bin= dings > >> and description for how to use them at runtime. Without idmac and = edmac > >> property, pio is the default transfer mode. Make sure that Idmac a= nd > >> emdac > >> should not be used simultaneously. > >>=20 > >> Signed-off-by: Shawn Lin > >> --- > >>=20 > >> Changes in v3: None > >> Changes in v2: None > >>=20 > >> .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 41 > >> ++++++++++++++++++++++ 1 file changed, 41 insertions(+) > >>=20 > >> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-msh= c.txt > >> b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt index > >> 346c609..30369cb 100644 > >> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > >> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > >>=20 > >> @@ -75,6 +75,25 @@ Optional properties: > >> * vmmc-supply: The phandle to the regulator to use for vmmc. If= this > >> is > >> =20 > >> specified we'll defer probe until we can find this regulator. > >>=20 > >> +* supports-idmac: Enables support for internal DMAC block within = the > >> Synopsys + Designware Mobile Storage IP block. If supports-idmac > >> property is present, then + we MUST NOT add supports-edmac proper= ty > >> since we'd assume that dw-mshc IP is + integrated with only one t= ype of > >> dma master. > >> + > >> +* supports-edmac: Enables support for external DMAC block outside= the > >> Synopsys + Designware Mobile Storage IP block. If supports-edmac > >> property is present, then + we MUST NOT add supports-idmac proper= ty > >> since we'd assume that dw-mshc IP is + integrated with only one t= ype of > >> dma master. > >> + > >> + (Without "supports-idmac" and "supports-edmac", use PIO as defa= ult > >> transfer mode)>=20 > > Aren't you breaking here backward compatibility with existing DTB? > >=20 > > Best regards, > > Krzysztof >=20 > Thanks, Krzysztof. > I guess you mean that I should keep existing DTB w/o these two > properties work fine using idmac? yep > >> + > >> +* dmas: List of DMA specifiers with the controller specific forma= t as > >> described + in the generic DMA client binding. This property shou= ld be > >> combined with + supports-edmac. Refer to dma.txt for details. > >> + > >> +* dma-names: DMA request names. Must be "rx-tx". And This propert= y > >> should be + combined with supports-edmac. Refer to dma.txt for de= tails. > >> + Similarly the use of an external dmac could simply be detected, by the=20 presence of the dma-* properties. So when the machine defines dma chann= els use=20 the external dma, otherwise the internal (or none). So you wouldn't nee= d=20 separate new properties at all. > >>=20 > >> Aliases: > >> =20 > >> - All the MSHC controller nodes should be represented in the ali= ases > >> node using>>=20 > >> @@ -95,6 +114,8 @@ board specific portions as listed below. > >>=20 > >> #size-cells =3D <0>; > >> =09 > >> }; > >>=20 > >> +[board specific internal DMA resources] > >> + > >>=20 > >> dwmmc0@12200000 { > >> =09 > >> clock-frequency =3D <400000000>; > >> clock-freq-min-max =3D <400000 200000000>; > >>=20 > >> @@ -106,4 +127,24 @@ board specific portions as listed below. > >>=20 > >> bus-width =3D <8>; > >> cap-mmc-highspeed; > >> cap-sd-highspeed; > >>=20 > >> + supports-idmac; > >>=20 > >> }; > >>=20 > >> + > >> +[board specific generic DMA request binding] > >> + > >> + dwmmc0@12200000 { > >> + clock-frequency =3D <400000000>; > >> + clock-freq-min-max =3D <400000 200000000>; > >> + num-slots =3D <1>; > >> + broken-cd; > >> + fifo-depth =3D <0x80>; > >> + card-detect-delay =3D <200>; > >> + vmmc-supply =3D <&buck8>; > >> + bus-width =3D <8>; > >> + cap-mmc-highspeed; > >> + cap-sd-highspeed; > >> + supports-edmac; > >> + dmas =3D <&pdma 12>; > >> + dma-names =3D "rx-tx"; > >> + }; > >> +