All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, Xiaoyun Li <xiaoyun.li@intel.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH] app/testpmd: fix build without drivers
Date: Fri, 25 Feb 2022 17:44:28 +0100	[thread overview]
Message-ID: <2573646.X9hSmTKtgW@thomas> (raw)
In-Reply-To: <Yhj62UEAzwTTvJnP@bricha3-MOBL.ger.corp.intel.com>

25/02/2022 16:50, Bruce Richardson:
> On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote:
> > When ixgbe and bnxt are disabled, compilation was failing:
> > 
> > app/test-pmd/cmdline.c:9396:11: error:
> > 	variable 'vf_rxmode' set but not used
> > 
> > Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  app/test-pmd/cmdline.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> > index b4ba8da2b0..7ab0575e64 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -9409,6 +9409,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
> >  	}
> >  
> >  	RTE_SET_USED(is_on);
> > +	RTE_SET_USED(vf_rxmode);
> >  
> Checking the code, I see the issue and the fix looks correct. However,
> doing some basic builds disabling the relevant drivers, and all drivers, in
> fact, I fail to reproduce the actual error message. Does this error only
> occur at lower optimization levels, or only using clang or similar?

I don't remember, probably clang only.



  reply	other threads:[~2022-02-25 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 15:26 [PATCH] app/testpmd: fix build without drivers Thomas Monjalon
2022-02-25 15:50 ` Bruce Richardson
2022-02-25 16:44   ` Thomas Monjalon [this message]
2022-02-25 16:53   ` Ajit Khaparde
2022-02-25 17:33     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2573646.X9hSmTKtgW@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=aman.deep.singh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.