From: "Martin Hundebøll" <martin@geanix.com>
To: Randy MacLeod <randy.macleod@windriver.com>,
Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org, Khem Raj <raj.khem@gmail.com>
Subject: Re: [PATCH 3/5] ninja: build modified version with GNU Make jobserver support
Date: Sat, 18 May 2024 09:13:45 +0200 [thread overview]
Message-ID: <25736e15345c70d9ba4e21de106429b66a99cbae.camel@geanix.com> (raw)
In-Reply-To: <b4aacad7-313d-4fdc-84c1-e1717f32ccc0@windriver.com>
Hi Randy,
On Mon, 2024-04-08 at 17:39 -0400, Randy MacLeod wrote:
> On 2024-04-03 3:08 p.m., Martin Hundebøll wrote:
> > On Wed, 2024-04-03 at 17:58 +0200, Alexander Kanavin wrote:
> > > We can't carry this mass of patches. It has to land upstream
> > > first.
> > >
> > Understandable.
> > >
> > > Are you able/willing to drive the upstream pull request to
> > > completion?
> > >
> > No, I don't think so. I'm not familiar with the ninja codebase, and
> > the
> > pull requests has been lingering for too long.
> >
> > Another option might be to propose adding the fifo feature to the
> > kitware fork of ninja:
> > https://github.com/Kitware/ninja
> >
> > They have forked ninja to get the jobserver feature in, but haven't
> > taken the fifo part so far.
> >
> > The kitware fork is also used by buildroot:
> > https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/ninja/ninja.mk
> >
> I see that v2 has switched to kitware, which is fine in the short
> run.
>
> I'm just back from vacation. I plan to test this patchset out.
>
> I can spend some time convincing upstream ninja that a solution is
> needed for our use-case and
> that perhaps the jobsever approach and the kitware fork is a good
> starting point.
>
> Of course, I can't promise to "drive it to completion" but I'll
> hound the upstream devs for months or even years!
>
> Thanks for re-submitting the patchset Martin!
>
I got hit by a strike of motivation and submitted a new attempt on
jobserver support to ninja:
https://github.com/ninja-build/ninja/pull/2450
First review from the ninja maintainer seems positive. I'll resubmit
the my patchset to OE once the ninja PR is (hopefully) merged.
// Martin
next prev parent reply other threads:[~2024-05-18 7:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 7:01 [PATCH 0/5] Jobserver support Martin Hundebøll
2024-04-03 7:02 ` [PATCH 1/5] classes: jobserver: support gnu make fifo jobserver Martin Hundebøll
2024-04-04 7:56 ` [OE-core] " Andreas Helbech Kleist
2024-04-04 7:58 ` Martin Hundebøll
2024-04-03 7:02 ` [PATCH 2/5] scripts: build-env: allow passing JOBSERVER_FIFO from environment Martin Hundebøll
2024-04-03 7:02 ` [PATCH 3/5] ninja: build modified version with GNU Make jobserver support Martin Hundebøll
2024-04-03 7:26 ` Patchtest results for " patchtest
2024-04-03 15:58 ` Alexander Kanavin
2024-04-03 19:08 ` Martin Hundebøll
2024-04-08 21:39 ` Randy MacLeod
2024-05-18 7:13 ` Martin Hundebøll [this message]
2024-04-03 7:02 ` [PATCH 4/5] qemu: enable parallel builds when using the jobserver class Martin Hundebøll
2024-04-03 7:02 ` [PATCH 5/5] contrib: add python service and systemd unit to run shared jobserver Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25736e15345c70d9ba4e21de106429b66a99cbae.camel@geanix.com \
--to=martin@geanix.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.