From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH] drm/i915: Check fb stride against plane max stride Date: Fri, 21 Sep 2018 15:17:45 -0700 Message-ID: <2577088.l8ySodvzlW@dk> References: <20180918140243.12207-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6A8D6E004 for ; Sat, 22 Sep 2018 23:03:04 +0000 (UTC) In-Reply-To: <20180918140243.12207-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: dhinakaran.pandiyan@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVHVlc2RheSwgU2VwdGVtYmVyIDE4LCAyMDE4IDc6MDI6NDMgQU0gUERUIFZpbGxlIFN5cmph bGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiAKPiBjb21taXQgNGUwYjgzYTU2N2UyICgiZHJtL2k5MTU6IEV4dHJhY3QgcGVy LXBsYXRmb3JtIHBsYW5lLT5jaGVjaygpCj4gZnVuY3Rpb25zIikgcmVtb3ZlZCB0aGUgcGxhbmUg bWF4IHN0cmlkZSBjaGVjayBmb3Igc3ByaXRlIHBsYW5lcy4KPiBJIHdhcyBnb2luZyB0byBhZGQg aXQgYmFjayB3aGVuIGludHJvZHVjaW5nIEdUVCByZW1hcHBpbmcgZm9yIHRoZQo+IGRpc3BsYXks IGJ1dCBhZnRlciBmdXJ0aGVyIHRob3VnaHQgaXQgc2VlbXMgYmV0dGVyIHRvIHJlLWludHJvZHVj ZQo+IGl0IHNlcGFyYXRlbHkuCj4gCj4gU28gbGV0J3MgYWRkIHRoZSBtYXggc3RyaWRlIGNoZWNr IGJhY2suIEFuZCBsZXQncyBkbyBpdCBpbiBhIG5pY2VyCj4gZm9ybSB0aGFuIHdoYXQgd2UgaGFk IGJlZm9yZSBhbmQgZG8gaXQgZm9yIGFsbCBwbGFuZSB0eXBlcyAoZWFzeQo+IG5vdyB0aGF0IHdl IGhhdmUgdGhlIC0+bWF4X3N0cmlkZSgpIHBsYW5lIHZmdW5jKS4KPiAKPiBPbmx5IHNwcml0ZSBw bGFuZXMgcmVhbGx5IG5lZWQgdGhpcyBmb3Igbm93IHNpbmNlIHByaW1hcnkgcGxhbmVzCj4gYXJl IGNhcGFibGUgb2Ygc2Nhbm5pbmcgb3V0IHRoZSBjdXJyZW50IG1heCBmYiBzaXplIHdlIGFsbG93 LCBhbmQKPiBjdXJzb3JzIGhhdmUgbW9yZSBzdHJpbmdlbnQgc3RyaWRlIGNoZWNrcyBlbHNld2hl cmUuCj4gCj4gQ2M6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29t Pgo+IEZpeGVzOiA0ZTBiODNhNTY3ZTIgKCJkcm0vaTkxNTogRXh0cmFjdCBwZXItcGxhdGZvcm0g cGxhbmUtPmNoZWNrKCkKPiBmdW5jdGlvbnMiKSBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxNCArKysrKysrKysrKysrKwo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Nwcml0ZS5jICB8IDIyICsrKysrKysrKysrKysrKysrKysrKysKPiAgMyBmaWxlcyBj aGFuZ2VkLCAzNyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGluZGV4IGViMjUwMzdkN2IzOC4uMWViOTlkNWVjMjIxCj4gMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTMxNTEsNiArMzE1MSwxMCBAQCBpbnQgc2ts X2NoZWNrX3BsYW5lX3N1cmZhY2Uoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlCj4gKnBsYW5lX3N0 YXRlKSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0uc3RyaWRlID0gaW50ZWxfZmJfcGl0Y2go ZmIsIDAsCj4gcm90YXRpb24pOyBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMV0uc3RyaWRlID0g aW50ZWxfZmJfcGl0Y2goZmIsIDEsCj4gcm90YXRpb24pOwo+IAo+ICsJcmV0ID0gaW50ZWxfcGxh bmVfY2hlY2tfc3RyaWRlKHBsYW5lX3N0YXRlKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJl dDsKPiArCj4gIAlpZiAoIXBsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUpCj4gIAkJcmV0dXJuIDA7 Cj4gCj4gQEAgLTMyODYsMTAgKzMyOTAsMTUgQEAgaW50IGk5eHhfY2hlY2tfcGxhbmVfc3VyZmFj ZShzdHJ1Y3QKPiBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpIGludCBzcmNfeCA9IHBs YW5lX3N0YXRlLT5iYXNlLnNyYy54MSA+PiAxNjsKPiAgCWludCBzcmNfeSA9IHBsYW5lX3N0YXRl LT5iYXNlLnNyYy55MSA+PiAxNjsKPiAgCXUzMiBvZmZzZXQ7Cj4gKwlpbnQgcmV0Owo+IAo+ICAJ aW50ZWxfZmlsbF9mYl9nZ3R0X3ZpZXcoJnBsYW5lX3N0YXRlLT52aWV3LCBmYiwgcm90YXRpb24p Owo+ICAJcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLnN0cmlkZSA9IGludGVsX2ZiX3BpdGNo KGZiLCAwLCByb3RhdGlvbik7Cj4gCklzIHRoZXJlIGEgZ29vZCByZWFzb24gdG8gbm90ICBpbmxp bmUgdGhlIGNvZGUgPwoJaWYgKGNvbG9yX3BsYW5lWzBdLnN0cmlkZSA+IHBsYW5lLT5tYXhfc3Ry aWRlKCkpCgkJcmV0dXJuIC1FSU5WQUw7CgoKPiArCXJldCA9IGludGVsX3BsYW5lX2NoZWNrX3N0 cmlkZShwbGFuZV9zdGF0ZSk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICAJ aW50ZWxfYWRkX2ZiX29mZnNldHMoJnNyY194LCAmc3JjX3ksIHBsYW5lX3N0YXRlLCAwKTsKPiAK PiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDQpCj4gQEAgLTk2ODUsMTAgKzk2OTQsMTUg QEAgc3RhdGljIGludCBpbnRlbF9jdXJzb3JfY2hlY2tfc3VyZmFjZShzdHJ1Y3QKPiBpbnRlbF9w bGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpIHVuc2lnbmVkIGludCByb3RhdGlvbiA9Cj4gcGxhbmVf c3RhdGUtPmJhc2Uucm90YXRpb247Cj4gIAlpbnQgc3JjX3gsIHNyY195Owo+ICAJdTMyIG9mZnNl dDsKPiArCWludCByZXQ7Cj4gCj4gIAlpbnRlbF9maWxsX2ZiX2dndHRfdmlldygmcGxhbmVfc3Rh dGUtPnZpZXcsIGZiLCByb3RhdGlvbik7Cj4gIAlwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0u c3RyaWRlID0gaW50ZWxfZmJfcGl0Y2goZmIsIDAsIHJvdGF0aW9uKTsKPiAKPiArCXJldCA9IGlu dGVsX3BsYW5lX2NoZWNrX3N0cmlkZShwbGFuZV9zdGF0ZSk7Cj4gKwlpZiAocmV0KQo+ICsJCXJl dHVybiByZXQ7Cj4gKwo+ICAJc3JjX3ggPSBwbGFuZV9zdGF0ZS0+YmFzZS5zcmNfeCA+PiAxNjsK PiAgCXNyY195ID0gcGxhbmVfc3RhdGUtPmJhc2Uuc3JjX3kgPj4gMTY7Cj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCBpbmRleCBiZjFjMzg3MjhhNTkuLmEzNGMyZjFmOTE1OSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTIxNDAsNiArMjE0MCw3IEBAIHVuc2lnbmVk IGludCBza2xfcGxhbmVfbWF4X3N0cmlkZShzdHJ1Y3QgaW50ZWxfcGxhbmUKPiAqcGxhbmUsIHVu c2lnbmVkIGludCByb3RhdGlvbik7Cj4gIGludCBza2xfcGxhbmVfY2hlY2soc3RydWN0IGludGVs X2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAkJICAgIHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0 ZSAqcGxhbmVfc3RhdGUpOwo+ICtpbnQgaW50ZWxfcGxhbmVfY2hlY2tfc3RyaWRlKGNvbnN0IHN0 cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpOwo+ICBpbnQgaW50ZWxfcGxhbmVf Y2hlY2tfc3JjX2Nvb3JkaW5hdGVzKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZQo+ICpwbGFuZV9z dGF0ZSk7IGludCBjaHZfcGxhbmVfY2hlY2tfcm90YXRpb24oY29uc3Qgc3RydWN0IGludGVsX3Bs YW5lX3N0YXRlCj4gKnBsYW5lX3N0YXRlKTsKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nw cml0ZS5jIGluZGV4IGQ0YzhlMTBmYzkwYi4uNWZkMmY3YmYzOTI3Cj4gMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0yMzAsNiArMjMwLDI4IEBAIHZvaWQgaW50ZWxf cGlwZV91cGRhdGVfZW5kKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlCj4gKm5ld19jcnRjX3N0YXRl KSAjZW5kaWYKPiAgfQo+IAo+ICtpbnQgaW50ZWxfcGxhbmVfY2hlY2tfc3RyaWRlKGNvbnN0IHN0 cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBpbnRl bF9wbGFuZSAqcGxhbmUgPSB0b19pbnRlbF9wbGFuZShwbGFuZV9zdGF0ZS0+YmFzZS5wbGFuZSk7 Cj4gKwljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNl LmZiOwo+ICsJdW5zaWduZWQgaW50IHJvdGF0aW9uID0gcGxhbmVfc3RhdGUtPmJhc2Uucm90YXRp b247Cj4gKwl1MzIgc3RyaWRlLCBtYXhfc3RyaWRlOwo+ICsKPiArCS8qIEZJWE1FIG90aGVyIGNv bG9yIHBsYW5lcz8gKi8KRG9lc24ndCB0aGUgY29sb3IgcGxhbmUgMCBoYXZlIHRoZSBtYXggc3Ry aWRlIGFsd2F5cz8KCgo+ICsJc3RyaWRlID0gcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLnN0 cmlkZTsKPiArCW1heF9zdHJpZGUgPSBwbGFuZS0+bWF4X3N0cmlkZShwbGFuZSwgZmItPmZvcm1h dC0+Zm9ybWF0LAo+ICsJCQkJICAgICAgIGZiLT5tb2RpZmllciwgcm90YXRpb24pOwo+ICsKPiAr CWlmIChzdHJpZGUgPiBtYXhfc3RyaWRlKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiW0ZCOiVkXSBz dHJpZGUgKCVkKSBleGNlZWRzIFtQTEFORTolZDolc10gbWF4IHN0cmlkZQo+ICglZClcbiIsICsJ CQkgICAgICBmYi0+YmFzZS5pZCwgc3RyaWRlLAo+ICsJCQkgICAgICBwbGFuZS0+YmFzZS5iYXNl LmlkLCBwbGFuZS0+YmFzZS5uYW1lLCBtYXhfc3RyaWRlKTsKSW5jbHVkZSB0aGUgY29sb3IgcGxh bmUgbnVtYmVyIGluIHRoZSBkZWJ1ZyBwcmludD8KCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIGludCBpbnRlbF9wbGFuZV9jaGVja19zcmNf Y29vcmRpbmF0ZXMoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlCj4gKnBsYW5lX3N0YXRlKSB7Cj4g IAljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNlLmZi OwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=