From mboxrd@z Thu Jan 1 00:00:00 1970 From: EUNBONG SONG Subject: Re: Re: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8 Date: Fri, 22 Mar 2013 15:03:29 +0000 (GMT) Message-ID: <25790716.2181363964608452.JavaMail.weblogic@epml01> Reply-To: eunb.song@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=euc-kr Content-Transfer-Encoding: base64 Return-path: MIME-version: 1.0 Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" List-Id: linux-i2c@vger.kernel.org DQo+QmFzaWNhbGx5IE9LLCBidXQgeW91IGhhdmUgbG90cyBvZiB3aGl0ZXNwYWNlIGlzc3Vlcywg c28gSSBjYW4ndCBhcHBseQ0KPnlvdXIgcGF0Y2guIFBsZWFzZSByZXNlbmQgYW5kIG1ha2Ugc3Vy ZSBpdCBhcHBsaWVzLg0KDQpTb3JyeSwgSSByZXdyaXRlIG15IHBhdGNoIGhlcmUuDQoNClNpZ25l ZC1vZmYtYnk6IEV1bkJvbmcgU29uZyA8ZXVuYi5zb25nQHNhbXN1bmcuY29tPg0KIC0tLQ0KIGRy aXZlcnMvaTJjL2J1c3Nlcy9pMmMtb2N0ZW9uLmMgfCAgICA4ICsrKystLS0tDQogMSBmaWxlcyBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9k cml2ZXJzL2kyYy9idXNzZXMvaTJjLW9jdGVvbi5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1v Y3Rlb24uYw0KaW5kZXggOTM1NTg1ZS4uYjJlMzI1OSAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvaTJj L2J1c3Nlcy9pMmMtb2N0ZW9uLmMNCisrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtb2N0ZW9u LmMNCkBAIC0xODMsNyArMTgzLDcgQEAgc3RhdGljIGlycXJldHVybl90IG9jdGVvbl9pMmNfaXNy KGludCBpcnEsIHZvaWQgKmRldl9pZCkNCiAJc3RydWN0IG9jdGVvbl9pMmMgKmkyYyA9IGRldl9p ZDsNCiANCiAJb2N0ZW9uX2kyY19pbnRfZGlzYWJsZShpMmMpOw0KLQl3YWtlX3VwX2ludGVycnVw dGlibGUoJmkyYy0+cXVldWUpOw0KKwl3YWtlX3VwKCZpMmMtPnF1ZXVlKTsNCiANCiAJcmV0dXJu IElSUV9IQU5ETEVEOw0KIH0NCkBAIC0yMDYsOSArMjA2LDkgQEAgc3RhdGljIGludCBvY3Rlb25f aTJjX3dhaXQoc3RydWN0IG9jdGVvbl9pMmMgKmkyYykNCiANCiAJb2N0ZW9uX2kyY19pbnRfZW5h YmxlKGkyYyk7DQogDQotCXJlc3VsdCA9IHdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZV90aW1lb3V0 KGkyYy0+cXVldWUsDQotCQkJCQkJICBvY3Rlb25faTJjX3Rlc3RfaWZsZyhpMmMpLA0KLQkJCQkJ CSAgaTJjLT5hZGFwLnRpbWVvdXQpOw0KKwlyZXN1bHQgPSB3YWl0X2V2ZW50X3RpbWVvdXQoaTJj LT5xdWV1ZSwNCisJCQkJCW9jdGVvbl9pMmNfdGVzdF9pZmxnKGkyYyksDQorCQkJCQlpMmMtPmFk YXAudGltZW91dCk7DQogDQogCW9jdGVvbl9pMmNfaW50X2Rpc2FibGUoaTJjKTsNCiANCi0tIA0K MS43LjAuMQ0KDQpUaGFua3Mu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933614Ab3CVPDc (ORCPT ); Fri, 22 Mar 2013 11:03:32 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:28865 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932192Ab3CVPDa (ORCPT ); Fri, 22 Mar 2013 11:03:30 -0400 X-AuditID: cbfee691-b7f5f6d000002fda-2a-514c72c17d5d Date: Fri, 22 Mar 2013 15:03:29 +0000 (GMT) From: EUNBONG SONG Subject: Re: Re: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8 To: Wolfram Sang Cc: "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" Reply-to: eunb.song@samsung.com MIME-version: 1.0 X-MTR: 20130322145617396@eunb.song Msgkey: 20130322145617396@eunb.song X-EPLocale: ko_KR.euc-kr X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20130322145617396@eunb.song X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-type: text/plain; charset=euc-kr MIME-version: 1.0 Message-id: <25790716.2181363964608452.JavaMail.weblogic@epml01> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+Zpu7BIp9Ag0XneSwu75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAlfGul9f2Qu28VQc2fyFvYGxg6eLkZNDSEBFouX/d0YQW0LAROLC sqdMELaYxIV769m6GLmAapYxSpw4vYIJpqjz7BxGiOb5jBL7p4eD2CwCqhJXFrSwgthsAtoS b788ALOFBVIkdq/cCGaLCKhJHLrdCzaHWaBG4tWfKywQc+QlJp++zA5i8woISpyc+YQFYpeS xPt/s4HqOYDiyhL335RDhCUkZk2/wAph80rMaH8KVS4nMe3rGmYIW1ri/KwNjDC/LP7+GCrO L3Hs9g6wkSC9T+4Hw4zZvfkLG4QtIDH1zEGoVnWJO882sUPYfBJrFr5lgRmz69RyZpje+1vm Qn2lKDGl+yE7hK0l8eXHPjZ0X/EKOEg0L+lkmsCoPAtJahaS9llI2pHVLGBkWcUomlqQXFCc lF5kqlecmFtcmpeul5yfu4kRkhQm7mC8f8D6EGMyMEYmMkuJJucDk0peSbyhsZmRhamJqbGR uaUZacJK4rzqLdaBQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgPR+WVdlb3Xol6+jZO3NZB R+tZDD9P4tIwpawY8YSMb/d7WoQmzWY4ove3Vv1obJ5ThldI3ua9J657OZ29kLmz+4kFx+OT G28x7neOPtVwl8fkPvdvQ4cnMhM3NV7q557Jxi8f7x73OzynonFF8OuLJV2h4tc0PvDMqs6y umfQUWfBV+7wTImlOCPRUIu5qDgRAHiGkyUgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgk+LIzCtJLcpLzFFi42I5/e/2TN2DRT6BBgvesFtc3jWHzYHR4/Mm uQDGqAybjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWgjA2M9I1MTPSNjAz0Tg1grQwMDI1OgqoSM jHW/vrIXbOOpOLL5C3sDYwdPFyMnh5CAikTL/++MILaEgIlE59k5ULaYxIV769kgauYzSuyf Hg5iswioSlxZ0MIKYrMJaEu8/fIAzBYWSJHYvXIjmC0ioCZx6HYvE4jNLFAj8erPFRaIOfIS k09fZgexeQUEJU7OfMICsUtJ4v2/2UD1HEBxZYn7b8ohwhISs6ZfYIWweSVmtD+FKpeTmPZ1 DTOELS1xftYGuJMXf38MFeeXOHZ7B9hIkN4n94Nhxuze/IUNwhaQmHrmIFSrusSdZ5vYIWw+ iTUL37LAjNl1ajkzTO/9LXOhvlKUmNL9kB3C1pL48mMfG7qveAUcJJqXdDJNYJSbhSQ1C0n7 LCTtyGoWMLKsYhRNLUguKE5KrzDUK07MLS7NS9dLzs/dxAhOT88W7mD8ct76EKMAB6MSD6+G jnegEGtiWXFl7iFGCQ5mJRHepQU+gUK8KYmVValF+fFFpTmpxYcYk4HxN5FZSjQ5H5g680ri DY0NjA0NLc0NTA2NLEgTVhLnfdpqHSgkkJ5YkpqdmlqQWgSzhYmDU6qB8ZzqVFdrlVm5nRdE PlyPPZ3NeOFZ9PQDjLv0z8X8+9NlURUrvah8vcqC5z4LH3zXcEyRroraHn935RaT8GobwbJn Og86DrYG/o22irfRLtnAfrJWzlIxNN+9MUWjLDjvj7BYWPHU+f/vtbLc35LSFrPqkUareFr/ est48w9cPpNterSqvt5QYinOSDTUYi4qTgQAAyR7t5MDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r2MF3WKR014171 >Basically OK, but you have lots of whitespace issues, so I can't apply >your patch. Please resend and make sure it applies. Sorry, I rewrite my patch here. Signed-off-by: EunBong Song --- drivers/i2c/busses/i2c-octeon.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index 935585e..b2e3259 100644 --- a/drivers/i2c/busses/i2c-octeon.c +++ b/drivers/i2c/busses/i2c-octeon.c @@ -183,7 +183,7 @@ static irqreturn_t octeon_i2c_isr(int irq, void *dev_id) struct octeon_i2c *i2c = dev_id; octeon_i2c_int_disable(i2c); - wake_up_interruptible(&i2c->queue); + wake_up(&i2c->queue); return IRQ_HANDLED; } @@ -206,9 +206,9 @@ static int octeon_i2c_wait(struct octeon_i2c *i2c) octeon_i2c_int_enable(i2c); - result = wait_event_interruptible_timeout(i2c->queue, - octeon_i2c_test_iflg(i2c), - i2c->adap.timeout); + result = wait_event_timeout(i2c->queue, + octeon_i2c_test_iflg(i2c), + i2c->adap.timeout); octeon_i2c_int_disable(i2c); -- 1.7.0.1 Thanks.{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I