From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 14/22] drm: omapdrm: Keep vblank interrupt enabled while CRTC is active Date: Thu, 15 Dec 2016 16:51:57 +0200 Message-ID: <2580087.D9jCYKYxOH@avalon> References: <1481675266-24598-1-git-send-email-laurent.pinchart@ideasonboard.com> <1481675266-24598-15-git-send-email-laurent.pinchart@ideasonboard.com> <5fd3ff5e-e9e9-85c3-d9f2-b16d3524a677@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 119ED6E9DE for ; Thu, 15 Dec 2016 14:51:21 +0000 (UTC) In-Reply-To: <5fd3ff5e-e9e9-85c3-d9f2-b16d3524a677@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKCk9uIFRodXJzZGF5IDE1IERlYyAyMDE2IDE0OjUyOjQ3IFRvbWkgVmFsa2VpbmVu IHdyb3RlOgo+IE9uIDE0LzEyLzE2IDAyOjI3LCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4g SW5zdGVhZCBvZiBnb2luZyB0aHJvdWdoIGEgY29tcGxpY2F0ZWQgcHJpdmF0ZSBJUlEgcmVnaXN0 cmF0aW9uCj4gPiBtZWNoYW5pc20sIGhhbmRsZSB0aGUgdmJsYW5rIGludGVycnVwdCBhY3RpdmF0 aW9uIHdpdGggdGhlIHN0YW5kYXJkCj4gPiBkcm1fY3J0Y192YmxhbmtfZ2V0KCkgYW5kIGRybV9j cnRjX3ZibGFua19wdXQoKSBtZWNoYW5pc20uIFRoaXMgd2lsbCBsZXQKPiA+IHRoZSBEUk0gY29y ZSBrZWVwIHRoZSB2YmxhbmsgaW50ZXJydXB0IGVuYWJsZWQgYXMgbG9uZyBhcyBuZWVkZWQgdG8K PiA+IHVwZGF0ZSB0aGUgZnJhbWUgY291bnRlci4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTGF1 cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4gLS0t Cj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2NydGMuYyB8IDM4ICsrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9kcnYuaCAgfCAgMSArCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9pcnEu YyAgfCAgNCArKystCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyNSBk ZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJt L29tYXBfY3J0Yy5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY3J0Yy5jIGlu ZGV4IDgyN2FjNDZhNmQ1ZS4uMWY1MzcyMDQyNzA2Cj4gPiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY3J0Yy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v b21hcGRybS9vbWFwX2NydGMuYwo+ID4gQEAgLTM2LDggKzM2LDYgQEAgc3RydWN0IG9tYXBfY3J0 YyB7Cj4gPiAKPiA+ICAJc3RydWN0IHZpZGVvbW9kZSB2bTsKPiA+IAo+ID4gLQlzdHJ1Y3Qgb21h cF9kcm1faXJxIHZibGFua19pcnE7Cj4gPiAtCj4gPiAgCWJvb2wgaWdub3JlX2RpZ2l0X3N5bmNf bG9zdDsKPiA+ICAJYm9vbCBlbmFibGVkOwo+ID4gCj4gPiBAQCAtMzA0LDI1ICszMDIsMjQgQEAg dm9pZCBvbWFwX2NydGNfZXJyb3JfaXJxKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+IHVpbnQz Ml90IGlycXN0YXR1cykKPiA+ICAJRFJNX0VSUk9SX1JBVEVMSU1JVEVEKCIlczogZXJyb3JzOiAl MDh4XG4iLCBvbWFwX2NydGMtPm5hbWUsIAppcnFzdGF0dXMpOwo+ID4gIH0KPiA+IAo+ID4gLXN0 YXRpYyB2b2lkIG9tYXBfY3J0Y192YmxhbmtfaXJxKHN0cnVjdCBvbWFwX2RybV9pcnEgKmlycSwg dWludDMyX3QKPiA+IGlycXN0YXR1cykKPiA+ICt2b2lkIG9tYXBfY3J0Y192YmxhbmtfaXJxKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ICB7Cj4gPiAtCXN0cnVjdCBvbWFwX2NydGMgKm9tYXBf Y3J0YyA9Cj4gPiAtCQkJY29udGFpbmVyX29mKGlycSwgc3RydWN0IG9tYXBfY3J0YywgdmJsYW5r X2lycSk7Cj4gPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvbWFwX2NydGMtPmJhc2UuZGV2 Owo+ID4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSAmb21hcF9jcnRjLT5iYXNlOwo+ID4gKwlz dHJ1Y3Qgb21hcF9jcnRjICpvbWFwX2NydGMgPSB0b19vbWFwX2NydGMoY3J0Yyk7Cj4gPiArCWJv b2wgcGVuZGluZzsKPiA+IAo+ID4gIAlpZiAoZGlzcGNfbWdyX2dvX2J1c3kob21hcF9jcnRjLT5j aGFubmVsKSkKPiA+ICAJCXJldHVybjsKPiA+ICAJCj4gPiAgCURCRygiJXM6IGFwcGx5IGRvbmUi LCBvbWFwX2NydGMtPm5hbWUpOwo+ID4gCj4gPiAtCV9fb21hcF9pcnFfdW5yZWdpc3RlcihkZXYs ICZvbWFwX2NydGMtPnZibGFua19pcnEpOwo+ID4gLQo+ID4gIAlzcGluX2xvY2soJmNydGMtPmRl di0+ZXZlbnRfbG9jayk7Cj4gPiAKPiA+IC0JV0FSTl9PTighb21hcF9jcnRjLT5wZW5kaW5nKTsK PiA+ICsJcGVuZGluZyA9IG9tYXBfY3J0Yy0+cGVuZGluZzsKPiA+IAo+ID4gIAlvbWFwX2NydGMt PnBlbmRpbmcgPSBmYWxzZTsKPiA+ICAJc3Bpbl91bmxvY2soJmNydGMtPmRldi0+ZXZlbnRfbG9j ayk7Cj4gPiAKPiA+ICsJaWYgKHBlbmRpbmcpCj4gPiArCQlkcm1fY3J0Y192YmxhbmtfcHV0KGNy dGMpOwo+ID4gKwo+IAo+IEkgdGhpbmsgdGhlcmUncyBhIHJhY2UuCj4gCj4gLSBpcnE6IHdlIGdl dCB2YmxhbmsgaXJxCj4gLSBpcnE6IEdPIGlzIG5vdCBzZXQsIHNvIGRpc3BjX21ncl9nb19idXN5 KCkgY2hlY2sgZG9lc24ndCB0cmlnZ2VyCj4gLSBmbHVzaDogd2Ugc2V0IEdPCj4gLSBmbHVzaDog d2UgbG9jayBldmVudF9sb2NrIGFuZCBzZXQgdGhlIHBlbmRpbmcgJiBldmVudCwgYW5kIHVubG9j awo+IC0gaXJxOiBpcnEgaGFuZGxlciBjb250aW51ZXMsIHNlZXMgcGVuZGluZyBhbmQgZXZlbnQs IGFuZCB0aGlua3MgdGhhdAo+IHRoZSBjb25maWcgaGFzIGJlZW4gdGFrZW4gaW50byB1c2UsIGJ1 dCBpbiByZWFsaXR5IEdPIGJpdCBpcyBzZXQgYW5kCj4gaXQnbGwgaGFwcGVuIG9ubHkgb24gbmV4 dCB2YmxhbmsuCgpJIHRoaW5rIHlvdSdyZSByaWdodC4gSSdsbCB0cnkgdG8gZml4IGl0LgoKPiA+ ICAJLyogd2FrZSB1cCB1c2Vyc3BhY2UgKi8KPiA+ICAJb21hcF9jcnRjX2NvbXBsZXRlX3BhZ2Vf ZmxpcCgmb21hcF9jcnRjLT5iYXNlKTsKPiA+IAo+ID4gQEAgLTM0MCw4ICszMzcsNiBAQCBzdGF0 aWMgdm9pZCBvbWFwX2NydGNfZGVzdHJveShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAKPiA+ ICAJREJHKCIlcyIsIG9tYXBfY3J0Yy0+bmFtZSk7Cj4gPiAKPiA+IC0JV0FSTl9PTihvbWFwX2Ny dGMtPnZibGFua19pcnEucmVnaXN0ZXJlZCk7Cj4gPiAtCj4gPiAgCWRybV9jcnRjX2NsZWFudXAo Y3J0Yyk7Cj4gPiAgCQo+ID4gIAlrZnJlZShvbWFwX2NydGMpOwo+ID4gQEAgLTM1MywxNCArMzQ4 LDEzIEBAIHN0YXRpYyB2b2lkIG9tYXBfY3J0Y19lbmFibGUoc3RydWN0IGRybV9jcnRjICpjcnRj KQo+ID4gCj4gPiAgCURCRygiJXMiLCBvbWFwX2NydGMtPm5hbWUpOwo+ID4gCj4gPiArCWRybV9j cnRjX3ZibGFua19vbihjcnRjKTsKPiA+ICsJV0FSTl9PTihkcm1fY3J0Y192YmxhbmtfZ2V0KGNy dGMpICE9IDApOwo+ID4gKwo+ID4gIAlzcGluX2xvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xv Y2spOwo+ID4gIAlXQVJOX09OKG9tYXBfY3J0Yy0+cGVuZGluZyk7Cj4gPiAgCW9tYXBfY3J0Yy0+ cGVuZGluZyA9IHRydWU7Cj4gPiAgCXNwaW5fdW5sb2NrX2lycSgmY3J0Yy0+ZGV2LT5ldmVudF9s b2NrKTsKPiA+IC0KPiA+IC0Jb21hcF9pcnFfcmVnaXN0ZXIoY3J0Yy0+ZGV2LCAmb21hcF9jcnRj LT52YmxhbmtfaXJxKTsKPiA+IC0KPiA+IC0JZHJtX2NydGNfdmJsYW5rX29uKGNydGMpOwo+ID4g IH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBvbWFwX2NydGNfZGlzYWJsZShzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMpCj4gPiBAQCAtNDE0LDggKzQwOCw2IEBAIHN0YXRpYyB2b2lkIG9tYXBfY3J0Y19h dG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRjCj4gPiAqY3J0YywKPiA+ICB7Cj4gPiAgCXN0cnVj dCBvbWFwX2NydGMgKm9tYXBfY3J0YyA9IHRvX29tYXBfY3J0YyhjcnRjKTsKPiA+IAo+ID4gLQlX QVJOX09OKG9tYXBfY3J0Yy0+dmJsYW5rX2lycS5yZWdpc3RlcmVkKTsKPiA+IC0KPiA+ICAJaWYg KGNydGMtPnN0YXRlLT5jb2xvcl9tZ210X2NoYW5nZWQpIHsKPiA+ICAJCXN0cnVjdCBkcm1fY29s b3JfbHV0ICpsdXQgPSBOVUxMOwo+ID4gIAkJdWludCBsZW5ndGggPSAwOwo+ID4gQEAgLTQ0MSw2 ICs0MzMsMTAgQEAgc3RhdGljIHZvaWQgb21hcF9jcnRjX2F0b21pY19mbHVzaChzdHJ1Y3QgZHJt X2NydGMKPiA+ICpjcnRjLAo+ID4gCj4gPiAgCURCRygiJXM6IEdPIiwgb21hcF9jcnRjLT5uYW1l KTsKPiA+IAo+ID4gKwlkaXNwY19tZ3JfZ28ob21hcF9jcnRjLT5jaGFubmVsKTsKPiA+ICsKPiA+ ICsJV0FSTl9PTihkcm1fY3J0Y192YmxhbmtfZ2V0KGNydGMpICE9IDApOwo+IAo+IEkgZG9uJ3Qg bGlrZSB0aGlzIHN0eWxlIHZlcnkgbXVjaC4gSSB0aGluayBXQVJOKClzIHNob3VsZCBiZSB3aXRo b3V0Cj4gc2lkZSBlZmZlY3RzLgo+IAo+IEFsc28sIFdBUk4gb25seSBnaXZlcyBiZW5lZml0IHdo ZW4gd2UgZG9uJ3Qga25vdyB3aGF0IHRoZSBjYWxsIHN0YWNrIGlzLgo+IEFmYWlrLCB0aGVyZSdz IG9ubHkgb25lIHdheSBvbWFwX2NydGNfYXRvbWljX2ZsdXNoIGNhbiBiZSBjYWxsZWQsIHNvCj4g aXQncyBqdXN0IGV4dHJhIHNwYW0gYW5kIGRldl9lcnIgb3IgZGV2X3dhcm4gc2hvdWxkIGJlIGVu b3VnaC4KCkkndmUgdXNlZCBpdCBiZWNhdXNlIHRoZSBlcXVpdmFsZW50IHN0YXRlbWVudHMgdGVz dGluZyBvbWFwX2NydGMtCj52YmxhbmtfaXJxLnJlZ2lzdGVyZWQgdXNlZCBXQVJOX09OKCkgdG9v LiBXQVJOX09OKCkgaXMgYWxzbyBhIGJpdCBtb3JlIHZvY2FsLCAKaXQgcmVhbGx5IGdldHMgdGhl IHBvaW50IGFjcm9zcy4gQXMgdGhlIGZ1bmN0aW9uIHJlYWxseSBzaG91bGQgbm90IHJldHVybiBh biAKZXJyb3IgdW5sZXNzIGluIGNhc2Ugb2YgYSBkcml2ZXIgYnVnLCBJIGRvbid0IHRoaW5rIGl0 IHdpbGwgZ2VuZXJhdGUgYW55IHNwYW0uIApJIGRvbid0IGNhcmUgdG9vIG11Y2ggdGhvdWdoLCBJ IGNhbiByZXBsYWNlIGl0IHdpdGggYSBkZXZfZXJyKCkgaWYgeW91IGluc2lzdC4KCi0tIApSZWdh cmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==