From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: next-20190826 - objtool fails to build.
Date: Wed, 28 Aug 2019 15:58:28 -0400 [thread overview]
Message-ID: <25813.1567022308@turing-police> (raw)
In-Reply-To: <20190828195100.tbkvphzhjtflrp66@treble>
On Wed, 28 Aug 2019 14:51:00 -0500, Josh Poimboeuf said:
> > The real question then becomes - should the Makefile sanitize CFLAGS or just
> > append to whatever the user supplied as it does currently? The rest of the tree
> > sanitizes CFLAG, because I don't get deluged in -Wsign-compare warnings all
> > over the place...
>
> Agreed. I assume this fixes it?
>
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index 88158239622b..20f67fcf378d 100644
> -CFLAGS += -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS)
> +CFLAGS := -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS)
Yep, thanks. Feel free to stick these on the final version:
Reported-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Tested-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
prev parent reply other threads:[~2019-08-28 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 4:15 next-20190826 - objtool fails to build Valdis Klētnieks
2019-08-28 15:10 ` Josh Poimboeuf
2019-08-28 19:30 ` Valdis Klētnieks
2019-08-28 19:51 ` Josh Poimboeuf
2019-08-28 19:58 ` Valdis Klētnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25813.1567022308@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.