From: Alexander Stein <alexander.stein@systec-electronic.com>
To: John Crispin <john@phrozen.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, Mathias Kresin <openwrt@kresin.me>,
"Mehrtens, Hauke" <hauke.mehrtens@intel.com>
Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver
Date: Thu, 19 May 2016 09:28 +0200 [thread overview]
Message-ID: <2585855.A9idatFmvt@ws-stein> (raw)
In-Reply-To: <5f2d9a6d-bcf1-5aa1-7c45-f8cfd723bc3a@phrozen.org>
On Thursday 19 May 2016 09:03:26, John Crispin wrote:
> [ changing haukes mail addr to the intel one ]
>
> On 19/05/2016 08:57, Alexander Stein wrote:
> > Hi John,
> >
> > On Thursday 19 May 2016 06:50:56, John Crispin wrote:
> >> On 18/05/2016 18:24, Florian Fainelli wrote:
> >>> CC'ing Andrew, John,
> >>
> >> also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for
> >> several years that seems a little more complete than this one.
> >>
> >> https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/lantiq/p
> >> atc
> >> hes-4.4/0023-NET-PHY-adds-driver-for-lantiq-PHY11G.patch;h=93bb4275ec1d2
> >> 61f3 98afb8fdc879c1dd973f997;hb=HEAD
> >
> > Thanks for the link, I wasn't aware of that patch. I like it in general,
> > but there are some things I'd like to get addressed first:
> > * vr9_gphy_of_reg_init() writes uncoditionally to led3h and led3l even on
> >
> > PEf7071 which does not have this register at all
>
> we use this driver mainly on the 11g and 22f version. mathias recently
> added the led3 handling.
>
> @Mathias, can you have a look at this and fix it inside the lede tree ?
>
> > * Why is PHY_HAS_INTERRUPT commented out everywhere?
>
> legacy code, the old mips silicon had a bug and the internal phys irq
> lines worked unreliably so we used polling instead. rather than remove
> the code i just disabled that part. code is not cleaned up yet for
> upstream submission as you can tell :-)
Would you or Mathias mind dropping a cleaned up patch to netdev ml, cc'ing me?
I can try it on our hardware using the 11g. Maybe I can even test the IRQ
feature.
Regards,
Alexander
next prev parent reply other threads:[~2016-05-19 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:03 [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein
2016-05-18 16:24 ` Florian Fainelli
2016-05-18 17:01 ` Andrew Lunn
2016-05-19 7:05 ` Alexander Stein
2016-05-19 12:15 ` Andrew Lunn
2016-05-19 4:50 ` John Crispin
2016-05-19 6:57 ` Alexander Stein
2016-05-19 7:03 ` John Crispin
2016-05-19 7:28 ` Alexander Stein [this message]
2016-05-19 10:03 ` Mathias Kresin
2016-05-19 10:21 ` Alexander Stein
2016-05-23 9:12 ` Mehrtens, Hauke
2016-05-23 9:49 ` Alexander Stein
2016-05-23 10:07 ` Mathias Kresin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2585855.A9idatFmvt@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hauke.mehrtens@intel.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openwrt@kresin.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.