From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Patrick Steinhardt" <ps@pks.im>,
"Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: history: 'reword HEAD' surfaces a memory leak
Date: Thu, 10 Sep 2026 17:27:48 +0200 [thread overview]
Message-ID: <2589b284-28ea-4724-8aaf-5ca438957755@app.fastmail.com> (raw)
In-Reply-To: <ap6qQPL7dPjZy1lO@pks.im>
On Mon, Sep 7, 2026, at 14:12, Patrick Steinhardt wrote:
> On Mon, Sep 07, 2026 at 05:16:44PM +0530, Kaartic Sivaraam wrote:
>> On 9/7/26 16:43, Patrick Steinhardt wrote:
>> >
>> > This feels familiar, even though it doesn't reproduce on my machine. Do
>> > you have "i18n.commitencoding" set? In any case, I think the following
>> > patch should fix it:
>> >
>> >[snip]
>> >
>>
>> My bad, I suppose. There was a suggestion by Peff that the commit message
>> was misleading. Per [2], the leak only happens when we get a commit that
>> isn't cached in the commit slab. I was trying to identify the specific case
>> in which we get a commit that's not cached in the slab but eventually got
>> busy with other work. I will get around to it soon and send a long pending
>> re-roll.
>>
>> [[ References ]]
>>
>> [2]:
>> https://lore.kernel.org/git/94b0bed5-c86a-4291-b958-52f09faebd29@gmail.com/
>
> Awesome, thanks!
Thanks, everyone. It makes sense that the commit graph was the
triggering factor.
prev parent reply other threads:[~2026-09-10 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 15:26 history: 'reword HEAD' surfaces a memory leak Kristoffer Haugsbakk
2026-09-07 11:13 ` Patrick Steinhardt
2026-09-07 11:46 ` Kaartic Sivaraam
2026-09-07 12:12 ` Patrick Steinhardt
2026-09-10 15:27 ` Kristoffer Haugsbakk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2589b284-28ea-4724-8aaf-5ca438957755@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.