From: Chris Mason <mason@suse.com>
To: "Stephen C. Tweedie" <sct@redhat.com>,
Wayne Whitney <whitney@math.berkeley.edu>
Cc: LKML <linux-kernel@vger.kernel.org>, ext2-devel@lists.sourceforge.net
Subject: Re: [OOPS 2.5.5-dj2] ext3 BUG in do_get_write_access()
Date: Fri, 01 Mar 2002 15:15:59 -0500 [thread overview]
Message-ID: <259120000.1015013734@tiny> (raw)
In-Reply-To: <20020301194155.H2682@redhat.com>
In-Reply-To: <Pine.LNX.4.44.0202281703130.4893-100000@mf1.private> <20020301194155.H2682@redhat.com>
On Friday, March 01, 2002 07:41:55 PM +0000 "Stephen C. Tweedie" <sct@redhat.com> wrote:
> In this particular case, I think I'll just have to relax the assertion
> and cause it to printk instead of BUG()ing, because I don't want to
> lose the protection of this test entirely.
>
> I'd really like to be able to detect such direct buffered-io
> "interference" from user-space, though, so that I could preserve the
> BUG() in cases where ext3 is getting this wrong internally. I'll look
> at that --- I may be able to achieve it through ext3's existing
> metadata flags.
Do I misunderstand the assertion? It seems to be saying:
'this buffer has been written out of order. If we were to crash
now, it will result in FS corruption'.
BUG()
If so, a printk alone might be better, since it would give the FS
the chance to put the correct data there anyway.
-chris
prev parent reply other threads:[~2002-03-01 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-01 1:19 [OOPS 2.5.5-dj2] ext3 BUG in do_get_write_access() Wayne Whitney
2002-03-01 18:59 ` Andreas Dilger
2002-03-01 19:41 ` Stephen C. Tweedie
2002-03-01 20:15 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259120000.1015013734@tiny \
--to=mason@suse.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=whitney@math.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.