From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
Narcisa.Vasile@microsoft.com, talshn@nvidia.com,
ferruh.yigit@intel.com, bruce.richardson@intel.com,
beilei.xing@intel.com, jia.guo@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows
Date: Fri, 18 Dec 2020 12:27:05 +0100 [thread overview]
Message-ID: <25941361.SrvSYD6x84@thomas> (raw)
In-Reply-To: <20201217225909.3580-3-pallavi.kadam@intel.com>
17/12/2020 23:59, Pallavi Kadam:
> Adds temp folder mlx5/windows as it is required to build this patch
> without any build error. This folder will be removed once mlx5 PMD
> patches are merged.
Why is it required?
> +if is_windows
> + build = false
> + reason = 'Not supported on Windows'
> + subdir_done()
> +endif
As you can see in other files, the reason starts always with a lowercase letter.
Please replace the first capital letter.
next prev parent reply other threads:[~2020-12-18 11:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 1:10 [dpdk-dev] [PATCH 0/3] Support i40e PMD on Windows Pallavi Kadam
2020-12-05 1:10 ` [dpdk-dev] [PATCH 1/3] eal/windows: add some interrupt functions stub Pallavi Kadam
2020-12-05 1:10 ` [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows Pallavi Kadam
2020-12-05 13:52 ` Dmitry Kozlyuk
2020-12-09 0:09 ` Kadam, Pallavi
2020-12-06 15:49 ` Thomas Monjalon
2020-12-07 9:14 ` Bruce Richardson
2020-12-09 0:14 ` Kadam, Pallavi
2020-12-09 0:21 ` Kadam, Pallavi
2020-12-09 8:59 ` Thomas Monjalon
2020-12-17 23:17 ` Kadam, Pallavi
2020-12-05 1:10 ` [dpdk-dev] [PATCH 3/3] config/build: ignore enum forward reference warning Pallavi Kadam
2020-12-05 13:51 ` Dmitry Kozlyuk
2020-12-10 0:53 ` Narcisa Ana Maria Vasile
2020-12-17 23:15 ` Kadam, Pallavi
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 0/2] Support i40e PMD on Windows Pallavi Kadam
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows Pallavi Kadam
2020-12-18 11:29 ` Thomas Monjalon
2020-12-18 18:49 ` Kadam, Pallavi
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows Pallavi Kadam
2020-12-18 11:27 ` Thomas Monjalon [this message]
2020-12-18 18:42 ` Kadam, Pallavi
2020-12-22 0:45 ` [dpdk-dev] [PATCH v3 0/2] Support " Pallavi Kadam
2020-12-22 0:45 ` [dpdk-dev] [PATCH v3 1/2] eal: add rte_random.c file on windows Pallavi Kadam
2020-12-22 0:45 ` [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows Pallavi Kadam
2021-01-08 22:58 ` Jie Zhou
2021-01-13 22:52 ` Thomas Monjalon
2021-01-13 22:55 ` Ranjit Menon
2021-01-13 23:10 ` Thomas Monjalon
2021-01-14 1:51 ` Tal Shnaiderman
2021-01-14 22:55 ` [dpdk-dev] [PATCH v3 0/2] Support " Thomas Monjalon
2021-01-14 23:06 ` Ranjit Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25941361.SrvSYD6x84@thomas \
--to=thomas@monjalon.net \
--cc=Narcisa.Vasile@microsoft.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.