Re: [PATCH] net: get rid of SET_ETHTOOL_OPS

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-07-02 10:07, Flavio Leitner:
> On Wed, Jul 02, 2014 at 11:48:51AM +0200, Thomas Monjalon wrote:
> > You are removing SET_ETHTOOL_OPS calls.
> 
> Yes.
> 
> > In a previous patch, Aaro Koskinen made the choice to redefine the macro
> > in kcompat files.
> 
> I missed that one.
> 
> > I don't know what will be the choice of Intel in the sourceforge base
> > driver. So I've applied Aaro's patch as there are less modifications of
> > the base> 
> > driver:
> > 	http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411
> 
> Since the macro is a simple pointer assignment, I didn't see any reason for
> keeping it around. But maybe I am missing something.

Me too. Except that this base driver is synchronized (sometimes) with the 
sourceforge one. So we should try to minimize differences with it.
That's why I'd prefer that people managing the sourceforge codebase push their 
patches here, or pull ours. But today, there is no rule.
Bonus game: who can find the commits of those projects?
	http://sourceforge.net/projects/e1000

-- 
Thomas