All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 15/15] drm: omapdrm: gem: Implement dma_buf import
Date: Sun, 06 Dec 2015 00:24:35 +0200	[thread overview]
Message-ID: <2598391.oC7TYoxACC@avalon> (raw)
In-Reply-To: <20151205154014.GS10243@phenom.ffwll.local>

Hi Daniel,

On Saturday 05 December 2015 16:40:14 Daniel Vetter wrote:
> On Sat, Dec 05, 2015 at 12:27:19AM +0200, Laurent Pinchart wrote:
> > OMAP GEM objects backed by dma_buf reuse the current OMAP GEM object
> > support as much as possible. If the imported buffer is physically
> > contiguous its physical address will be used directly, reusing the
> > OMAP_BO_MEM_DMA_API code paths. Otherwise it will be mapped through the
> > TILER using a pages list created from the scatterlist instead of the
> > shmem backing storage.
> > 
> > Disallow exporting imported buffers for now as those code paths haven't
> > been verified. Use cases of such a feature are suspicious anyway.
> 
> If you export a buffer that's been imported the drm_prime.c helpers should
> dig out the original dma-buf again. You should never end up with a dma-buf
> -> omap gem bo -> dma-buf chain.
> 
> If that doesn't work then there's a bug somewhere ...

Very good point. I'll drop the check. Thank you for the review.

> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > 
> >  drivers/gpu/drm/omapdrm/omap_drv.h        |   2 +
> >  drivers/gpu/drm/omapdrm/omap_gem.c        | 138 +++++++++++++++++++------
> >  drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c |  57 +++++++++---
> >  3 files changed, 163 insertions(+), 34 deletions(-)

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2015-12-05 22:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 22:27 [PATCH 00/15] omapdrm: Implement dma_buf import Laurent Pinchart
2015-12-04 22:27 ` [PATCH 01/15] drm: omapdrm: Fix plane state free in plane reset handler Laurent Pinchart
2015-12-09 12:43   ` Tomi Valkeinen
2015-12-13 20:39     ` Laurent Pinchart
2015-12-14  7:59       ` Tomi Valkeinen
2015-12-04 22:27 ` [PATCH 02/15] drm: omapdrm: Make fbdev emulation optional Laurent Pinchart
2015-12-04 22:27 ` [PATCH 03/15] drm: omapdrm: gem: Remove unused function prototypes Laurent Pinchart
2015-12-04 22:27 ` [PATCH 04/15] drm: omapdrm: gem: Remove forward declarations Laurent Pinchart
2015-12-04 22:27 ` [PATCH 05/15] drm: omapdrm: gem: Group functions by purpose Laurent Pinchart
2015-12-04 22:27 ` [PATCH 06/15] drm: omapdrm: gem: Move global usergart variable to omap_drm_private Laurent Pinchart
2015-12-04 22:27 ` [PATCH 07/15] drm: omapdrm: gem: Remove omap_drm_private has_dmm field Laurent Pinchart
2015-12-04 22:27 ` [PATCH 08/15] drm: omapdrm: gem: Mask out private flags passed from userspace Laurent Pinchart
2015-12-07 14:13   ` Emil Velikov
2015-12-14 20:33     ` Laurent Pinchart
2015-12-16 17:33       ` Emil Velikov
2015-12-16 23:27         ` Rob Clark
2015-12-04 22:27 ` [PATCH 09/15] drm: omapdrm: gem: Clean up GEM objects memory flags Laurent Pinchart
2015-12-04 22:27 ` [PATCH 10/15] drm: omapdrm: gem: Free the correct memory object Laurent Pinchart
2015-12-14 11:45   ` Tomi Valkeinen
2015-12-14 19:52     ` Laurent Pinchart
2015-12-04 22:27 ` [PATCH 11/15] drm: omapdrm: gem: Don't free mmap offset twice Laurent Pinchart
2015-12-04 22:27 ` [PATCH 12/15] drm: omapdrm: gem: Simplify error handling when creating GEM object Laurent Pinchart
2015-12-04 22:27 ` [PATCH 13/15] drm: omapdrm: gem: Remove check for impossible condition Laurent Pinchart
2015-12-04 22:27 ` [PATCH 14/15] drm: omapdrm: gem: Refactor GEM object allocation Laurent Pinchart
2015-12-04 22:27 ` [PATCH 15/15] drm: omapdrm: gem: Implement dma_buf import Laurent Pinchart
2015-12-05 15:40   ` Daniel Vetter
2015-12-05 22:24     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2598391.oC7TYoxACC@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.