From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] examples/ethtool: fix bug in drvinfo callback Date: Tue, 20 Dec 2016 18:21:57 +0100 Message-ID: <2599766.5RT2cabHtI@xps13> References: <1479462013-11562-1-git-send-email-qiming.yang@intel.com> <1479778884-26993-1-git-send-email-qiming.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Remy Horton To: Qiming Yang Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 616AEFBCD for ; Tue, 20 Dec 2016 18:21:59 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id g23so126675847wme.1 for ; Tue, 20 Dec 2016 09:21:59 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-23 09:00, Remy Horton: > Not sure this is a problem in practice, as the same set if fields is > updated each time...at least for now. > > On 22/11/2016 09:41, Qiming Yang wrote: > > Function pcmd_drvinfo_callback uses struct info to get > > the ethtool information of each port. Struct info will > > store the information of previous port until this > > information be updated. This patch fixes this issue. > > > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > > > > Signed-off-by: Qiming Yang > > Acked-by: Remy Horton Applied, thanks