From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NLk1d-0008Ny-Mb
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 16:06:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NLk1Y-0008LB-Uj
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 16:06:13 -0500
Received: from [199.232.76.173] (port=34772 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NLk1Y-0008Kq-LD
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 16:06:08 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:49275)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <andreas.faerber@web.de>) id 1NLk1Y-0000Z9-54
	for qemu-devel@nongnu.org; Fri, 18 Dec 2009 16:06:08 -0500
Message-Id: <25EB805F-FD36-4AA4-A2DB-BCF1F59FCDDE@web.de>
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
In-Reply-To: <1261150144-1702-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Subject: Re: [Qemu-devel] [PATCH] S390: Bail out whithout KVM
Date: Fri, 18 Dec 2009 22:05:44 +0100
References: <1261150144-1702-1-git-send-email-agraf@suse.de>
Sender: andreas.faerber@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Hi,

Am 18.12.2009 um 16:29 schrieb Alexander Graf:

> Currently only the S390 KVM target works. To keep users from  
> accidently not
> using KVM, let's not even initialize the machine when KVM is not used.

How does this fit together with your "S390 TCG target" patch? Aren't  
they mutually exclusive?  Is this one for stable?

Andreas

> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> hw/s390-virtio.c |    7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
> index b57fa9c..a33076a 100644
> --- a/hw/s390-virtio.c
> +++ b/hw/s390-virtio.c
> @@ -142,6 +142,13 @@ static void s390_init(ram_addr_t ram_size,
>     ram_addr_t initrd_size = 0;
>     int i;
>
> +    /* XXX we only work on KVM for now */
> +
> +    if (!kvm_enabled()) {
> +        fprintf(stderr, "The S390 target only works with KVM enabled 
> \n");
> +        exit(1);
> +    }
> +
>     /* get a BUS */
>     s390_bus = s390_virtio_bus_init(&ram_size);
>
> -- 
> 1.6.0.2
>
>
>