From: Gal Pressman <galp.dev@gmail.com>
To: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>,
davem@davemloft.net, linville@tuxdriver.com, saeedm@mellanox.com,
galp@mellanox.com, netdev@vger.kernel.org, odedw@mellanox.com,
ariela@mellanox.com, Yuval.Mintz@qlogic.com, tzahio@mellanox.com
Cc: roees@mellanox.com, aviadr@mellanox.com,
dustin@cumulusnetworks.com, roopa@cumulusnetworks.com
Subject: Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes
Date: Thu, 3 Nov 2016 15:24:32 +0200 [thread overview]
Message-ID: <25b7fce6-49f9-bd54-5c12-c72298d107c1@gmail.com> (raw)
In-Reply-To: <1477363849-36517-1-git-send-email-vidya@cumulusnetworks.com>
On 25/10/2016 05:50, Vidya Sagar Ravipati wrote:
> SET FEC option:
> root@tor: ethtool --set-fec swp1 encoding [off | RS | BaseR | auto] autoneg [off | on]
>
> Encoding: Types of encoding
> Off : Turning off any encoding
> RS : enforcing RS-FEC encoding on supported speeds
> BaseR : enforcing Base R encoding on supported speeds
> Auto : Default FEC settings for divers , and would represent
divers? :)
> asking the hardware to essentially go into a best effort mode.
>
> Here are a few examples of what we would expect if encoding=auto:
> - if autoneg is on, we are expecting FEC to be negotiated as on or off
> as long as protocol supports it
> - if the hardware is capable of detecting the FEC encoding on it's
> receiver it will reconfigure its encoder to match
> - in absence of the above, the configuration would be set to IEEE
> defaults.
Not sure I follow, why do we need an autoneg option if encoding type can be set to auto?
next prev parent reply other threads:[~2016-11-03 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 2:50 [RFC PATCH net-next] net: ethtool: add support for forward error correction modes Vidya Sagar Ravipati
2016-11-03 13:24 ` Gal Pressman [this message]
2016-11-08 21:33 ` Vidya Sagar Ravipati
-- strict thread matches above, loose matches on Subject: below --
2016-11-11 19:51 Casey Leedom
2016-11-22 23:30 ` Casey Leedom
2016-11-22 23:41 ` Casey Leedom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b7fce6-49f9-bd54-5c12-c72298d107c1@gmail.com \
--to=galp.dev@gmail.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=ariela@mellanox.com \
--cc=aviadr@mellanox.com \
--cc=davem@davemloft.net \
--cc=dustin@cumulusnetworks.com \
--cc=galp@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=odedw@mellanox.com \
--cc=roees@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=tzahio@mellanox.com \
--cc=vidya@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.