From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB276C6FA82 for ; Mon, 26 Sep 2022 16:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234945AbiIZQDK (ORCPT ); Mon, 26 Sep 2022 12:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234902AbiIZQCf (ORCPT ); Mon, 26 Sep 2022 12:02:35 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48966AC39B for ; Mon, 26 Sep 2022 07:50:44 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id e205so5429473iof.1 for ; Mon, 26 Sep 2022 07:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=pTDxk9oXLcyzLIlge9oEls0XIl60bM4FjSB09bCJi7I=; b=HYvDGszNu1gu6URMqy5VyPO0q1CjLZEc24iAopQm0fNr/8L0QweBd44p9s0Sy+yCiB ugqpaw+OzNCG5QFs9LmXrwSLt+OFDxXFtU4qrSW5Mq0MX75/UGFUftTXqK0UyXjEvFdh ZeP3ryaZrtP2yaocnW4b6ax+wiab+q3J3a23bPfNR12QrJRBe0vsqZMWHh4geLH+zGNv MdXBFXHKqXiFB0Dr9J4bRDOIJj2sfngS7KX7Y037Im/Fw/LEQdF6a5q6XT1ypWs7P+Jb JuwmSEAcV/ZQ4/YnWr3LwJEHbMHze15ZmdqBs68ASLe4yJWt1rSMDR4ipzZbTmfoTGpC 6shg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=pTDxk9oXLcyzLIlge9oEls0XIl60bM4FjSB09bCJi7I=; b=cs4z/GMqZfZSQr/DvxusgrqO1bbHKHWl7oSW/yfFxOku4UAsWAVRIssb0PJI7BdS9V +V4YP2BC1vIA0J1/gzjyN60hwfGAGcPEk0iubD7cXoFhuUPXv9cFkM+86VtveM/qvWa8 Xq6tPEcNoqpmleSE1BWXWVYW/qcOHBag0sIwLoIu2zZOQhqHnZ6IhwSkR2fU1jooqsb1 X39mHQJyC/AQPhiBZuEshSK0liYCwgYeVwJnUpWICf346NtPchRcfiK5Cs/PS+inKr9X 1tnOMFPLWHTBc6FIughMbhedD9+APtbA1BM4UOBKKRwHp8qmsO8vy9TeHIc/n0Z3Y4/h 9JxA== X-Gm-Message-State: ACrzQf1zNK0AC4GAjusnljEVOMv5EnlDYW2+yp/QAGdBLvwJM5hHjESj rO6mO3Jj5vIU2YBtYByUZmOTwQ== X-Google-Smtp-Source: AMsMyM4ezesDcR/VrCIT8c4MqwXXAKedbbvzEcJmc1qxfhQgzw/YFvqad1860zJhGdYZ9FeErmdgJw== X-Received: by 2002:a02:b681:0:b0:349:b7d5:7c25 with SMTP id i1-20020a02b681000000b00349b7d57c25mr11526271jam.228.1664203844319; Mon, 26 Sep 2022 07:50:44 -0700 (PDT) Received: from [192.168.1.94] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id e21-20020a056602159500b0067ba7abc4cesm7638553iow.50.2022.09.26.07.50.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 07:50:43 -0700 (PDT) Message-ID: <25b9899f-0c60-39f2-179b-789b914e0f0a@kernel.dk> Date: Mon, 26 Sep 2022 08:50:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 4/5] nvme: split out metadata vs non metadata end_io uring_cmd completions Content-Language: en-US To: Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, Stefan Roesch References: <20220922182805.96173-1-axboe@kernel.dk> <20220922182805.96173-5-axboe@kernel.dk> <69598e37-fb91-5b92-bb80-b68457a7b6f8@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 9/26/22 8:43 AM, Christoph Hellwig wrote: > On Mon, Sep 26, 2022 at 08:41:38AM -0600, Jens Axboe wrote: >> Sure, I don't really care. What name do you want for it? > > Maybe slow and fast? Or simple and meta? So you want 'result' in a named struct too then? Because right now it looks like this: struct nvme_uring_cmd_pdu { union { struct bio *bio; struct request *req; }; u32 meta_len; u32 nvme_status; union { struct { void *meta; /* kernel-resident buffer */ void __user *meta_buffer; }; u64 result; }; }; Or just the union named so it's clear it's a union? That'd make it pdu->u.meta and so forth. I think that might be cleaner. -- Jens Axboe