From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA04F13540A for ; Tue, 27 Feb 2024 09:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709025065; cv=none; b=Sd/eRwMxnV4BfxUyMgO6ihoeSXc/ojdFFvceTB7dXaxBr4DveZskufU1JJo7zlJp99fcYdE8hQIOiuS4xgW1j7CNP1IjmdAg3hZ0M8q0+z+TGsV+0RZXYpXIBWJfS8tE1DdpPzA2I4Z50PNjZFRz+bPfrwaOyx9RePmQ3/SWozw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709025065; c=relaxed/simple; bh=5gzv63ElqC8ZtnmO/nAOXii7GkJmtEzkbFiPZ8aQv4U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SC8fECO3uSg/U/GuDe1f2Q5aDdIuciJpPA7JPelvEyT9obVZmqRZ0uV77NP+9NmO9xPZgEV0aw+DogF2zFcUxcjGN9XX5Y8i/zbjtqCGhKZNcWuawRc+B3jZuURlNwFBEmFsQ2RiW3iIoroULJRrqF/rcwqNQwskUuhBqLpqNLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NDV9YE5E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NDV9YE5E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC003C433F1; Tue, 27 Feb 2024 09:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709025065; bh=5gzv63ElqC8ZtnmO/nAOXii7GkJmtEzkbFiPZ8aQv4U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NDV9YE5E0HUawB57SXMC9kr9yuyX8RXQqwRJ43FZFUOzBR7jUHNtSs2hPeUiu9CsE 5gUFq9BfKIgbt40VZ0NhOrXUI01TKU9RPS2otB/1TUydl5iuvF807Mocb2fr1CNYhI fxsT00YtQteiQDkSbLsGqzILZ7eJN+8aWUbLMFLX5T3wwV/Z+a1S91GLyUIv2qBbla B0ZtLkQcAMlEY+RphANEayyMs/CnNFENfJ/GRI0lTQkRm8PU0F5PsEJhssdtpZyBqA kdWaOT2ELL97C1UOTm/Qnf4/BMPxrjlh7pp3dDHa+wCWDnKu0FwUE83euWfpAxSfbP AQnb8CQfrcBIg== Message-ID: <25bb114b-5cdd-40d8-b087-b151dd3dc570@kernel.org> Date: Tue, 27 Feb 2024 10:11:03 +0100 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mptcp-next v2 0/7] some cleanups Content-Language: en-GB, fr-BE To: Geliang Tang Cc: mptcp@lists.linux.dev References: From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Geliang, On 27/02/2024 02:40, Geliang Tang wrote: > Hi Matt, > > On Mon, Feb 26, 2024 at 11:06:11AM +0100, Matthieu Baerts wrote: >> Hi Geliang, >> >> On 22/02/2024 09:03, Geliang Tang wrote: >>> From: Geliang Tang >>> >>> v2: >>> - address Matt's comments in v1 >> >> If you don't mind, I think it would be useful to add a short changelog >> per patch, under the commit message using '---' as separator (or using >> 'git notes'): it would help to remember what was discussed, what was >> applied, rejected or (accidentally or not) ignored. One line might be >> enough, but it would be useful. > > Sure, I'll use 'git notes' to add notes in the future. Thanks! >>> Geliang Tang (7): >>> mptcp: make pm_remove_addrs_and_subflows static >>> mptcp: drop duplicate header inclusions >>> mptcp: update set_flags interfaces >>> mptcp: set error messages for set_flags >>> mptcp: drop lookup_by_id in lookup_addr >> >> The five first patches look good to me: >> >> Reviewed-by: Matthieu Baerts (NGI0) >> >>> mptcp: add check_id for lookup_anno_list_by_saddr >>> selftests: mptcp: flush userspace addrs list >> >> Maybe the 6th patch can be simplified, and the 7th one can be dropped? > > Please apply the 5 first patches for me. I changed the states of them as > 'Queued' on patchwork, and 'Changes Requested' for the last two. I will do it here, but I think it would be better to avoid applying part of a series: the CI validated the whole series. Here, it is OK, just some individual cleanups, it looks fine! >> Also, please check my comments on patch 7: it is *really, really* >> important for you to explain the *reasoning for why patches were >> created*. Without a clear reason, we cannot accept patches. > > Thanks for the note on patch 7. I'll always explain the reason for the > patch in commit logs in the future. I promise. Great, thanks, that will help for the reviews and for later :) Cheers, Matt -- Sponsored by the NGI0 Core fund.