Re: [PATCH] tools/mm: -Werror fixes in page-types/slabinfo

[Wladislav Wiebe <wladislav.kw@gmail.com>]

On 24/10/2024 01:51, Andrew Morton wrote:
> On Tue, 22 Oct 2024 19:21:13 +0200 Wladislav Wiebe <wladislav.kw@gmail.com> wrote:
>
>> Commit e6d2c436ff693 ("tools/mm: allow users to provide
>> additional cflags/ldflags") passes now CFLAGS to Makefile.
>> With this, build systems with default -Werror enabled found:
>>
>> slabinfo.c:1300:25: error: ignoring return value of 'chdir'
>> declared with attribute 'warn_unused_result' [-Werror=unused-result]
>>                          chdir("..");
>>                          ^~~~~~~~~~~
>> page-types.c:397:35: error: format '%lu' expects argument of type
>> 'long unsigned int', but argument 2 has type 'uint64_t'
>> {aka 'long long unsigned int'} [-Werror=format=]
>>                          printf("%lu\t", mapcnt0);
>>                                  ~~^     ~~~~~~~
>> ..
>>
>> Fix page-types by using PRIu64 for uint64_t prints and check
>> in slabinfo for return code on chdir("..").
>>
> Thanks.
>
> Your email client messed this up in strange ways, so I basically typed
> it in again.  I added the Fixes: target and a cc:stable.

thanks for the feedback, seems something went wrong after updating my mail client, I will fix it.