Re: [PATCH libnftnl] object: define nftnl_obj_unset()

[Nicholas Vinson <nvinson234@gmail.com>]

On 1/3/24 05:32, Pablo Neira Ayuso wrote:

> Hi Nicholas,
>
> On Tue, Jan 02, 2024 at 12:50:58PM -0500, Nicholas Vinson wrote:
>> I manually applied this patch and got the following build error:
>>
>>      error: use of undeclared identifier 'nftnl_obj_unset'; did you mean
>>      'nftnl_obj_set'
>>
>> I think a declaration for nftnl_obj_unset() needs to be added to
>> include/libnftnl/object.h. Other than that, this patch looks OK to me.
> $ git grep nftnl_obj_unset
> include/libnftnl/object.h:void nftnl_obj_unset(struct nftnl_obj *ne, uint16_t attr);
> src/libnftnl.map:  nftnl_obj_unset;
> src/object.c:EXPORT_SYMBOL(nftnl_obj_unset);
> src/object.c:void nftnl_obj_unset(struct nftnl_obj *obj, uint16_t attr
>
> the header file already has a declaration for this (which was part of
> 5573d0146c1a ("src: support for stateful objects").
>
> What is missing then?

A mistake on my part. I failed to revert to properly revert my patch 
before testing this change.

Everything looks good to me.

Thanks.

>
> Thanks.