From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Nikolai Merinov <n.merinov@inango-systems.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] parse: Forbid ambiguous assignments to ${.}, ${+}, and ${:} variables
Date: Mon, 03 Feb 2025 17:40:09 +0000 [thread overview]
Message-ID: <25ed9291b59922108451bdec071f56efea34dec3.camel@linuxfoundation.org> (raw)
In-Reply-To: <20250203164235.1503956-1-n.merinov@inango-systems.com>
Hi Nikolai,
On Mon, 2025-02-03 at 18:42 +0200, Nikolai Merinov wrote:
> Hi Richard,
>
> > I'm worried that if we do what you patch does, we're complicating
> > the
> > code and potentially setting ourselves up for other new interesting
> > future problems.
>
> How about moving complicated part out of regular expression?
>
> Please take a look to the second version of the patch.
I prefer that version thanks!
If we can tweak the test name, I think we can merge that and I'll
continue to think about whether we should make the whitespace parsing
stricter.
Cheers,
Richard
next prev parent reply other threads:[~2025-02-03 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 18:55 [PATCH] parse: Forbid ambiguous assignments to ${.}, ${+}, and ${:} variables Nikolai Merinov
2025-01-31 20:40 ` [bitbake-devel] " Peter Kjellerstedt
2025-02-03 17:42 ` Richard Purdie
2025-02-04 11:11 ` Nikolai Merinov
2025-02-01 13:29 ` Richard Purdie
2025-02-03 16:42 ` Nikolai Merinov
2025-02-03 17:40 ` Richard Purdie [this message]
2025-02-04 7:13 ` Nikolai Merinov
2025-02-04 7:13 ` [PATCH v3 1/1] " Nikolai Merinov
2025-02-03 16:42 ` [PATCH v2] " Nikolai Merinov
2025-02-03 17:39 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ed9291b59922108451bdec071f56efea34dec3.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=n.merinov@inango-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.