From: Markus Elfring <Markus.Elfring@web.de>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Gyeyoung Baek <gye976@gmail.com>,
Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels
Date: Mon, 2 Sep 2024 15:35:37 +0200 [thread overview]
Message-ID: <25f3cbe5-1491-4f50-9971-d251c407879f@web.de> (raw)
In-Reply-To: <20240901151150.77074133@jic23-huawei>
> > 'flush_fifo' label performs same task as 'endsession' label
> > immediately after calling 'env_reset_fifo' function.
> > So i remove that duplication.
…
> Ok. This doesn't greatly affect readability and the code
> ends up a bit shorter.
How can you find such a change description acceptable?
> Applied
Please reconsider this positive feedback once more.
It temporarily looked too promising to apply a goto chain.
But the original control flow needs other development considerations
if you would like to reduce the explicit repetition of common actions.
Regards,
Markus
next prev parent reply other threads:[~2024-09-02 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 12:08 [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels Gyeyoung Baek
2024-09-01 14:11 ` Jonathan Cameron
2024-09-02 1:53 ` gyeyoung
2024-09-02 9:51 ` Jean-Baptiste Maneyrol
2024-09-02 13:35 ` Markus Elfring [this message]
2024-09-03 23:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f3cbe5-1491-4f50-9971-d251c407879f@web.de \
--to=markus.elfring@web.de \
--cc=Jean-Baptiste.Maneyrol@tdk.com \
--cc=gye976@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.