diff for duplicates of <2601556.jT3Q3TPugr@avalon> diff --git a/a/1.txt b/N1/1.txt index ee9a7bb..0a17638 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -94,7 +94,7 @@ expressed in DT, my bad. What about clkb though ? > > +Example > > +------- > > + -> > + cpg_clocks: cpg_clocks@ffc80000 { +> > + cpg_clocks: cpg_clocks at ffc80000 { > > + compatible = "renesas,r8a7779-cpg-clocks"; > > + reg = <0 0xffc80000 0 0x80>; > @@ -285,7 +285,7 @@ div); > > + > > + cpg = kzalloc(sizeof(*cpg), GFP_KERNEL); > > + clks = kzalloc(CPG_NUM_CLOCKS * sizeof(*clks), GFP_KERNEL); -> > + if (cpg = NULL || clks = NULL) { +> > + if (cpg == NULL || clks == NULL) { > > + /* We're leaking memory on purpose, there's no point in cleaning > > + * up as the system won't boot anyway. > > + */ @@ -299,7 +299,7 @@ div); > > + cpg->data.clk_num = num_clks; > > + > > + cpg->reg = of_iomap(np, 0); -> > + if (WARN_ON(cpg->reg = NULL)) +> > + if (WARN_ON(cpg->reg == NULL)) > > + return; As the driver doesn't access any of the CPG registers this could even be diff --git a/a/content_digest b/N1/content_digest index 8ebd78c..c5ed91c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\01393400016-23433-1-git-send-email-horms+renesas@verge.net.au\0" "ref\01393400016-23433-2-git-send-email-horms+renesas@verge.net.au\0" "ref\04148973.00y2RRnE7j@avalon\0" - "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" - "Subject\0Re: [PATCH v3 01/20] clk: shmobile: r8a7779: Add clocks support\0" - "Date\0Wed, 26 Feb 2014 13:02:37 +0000\0" + "From\0laurent.pinchart@ideasonboard.com (Laurent Pinchart)\0" + "Subject\0[PATCH v3 01/20] clk: shmobile: r8a7779: Add clocks support\0" + "Date\0Wed, 26 Feb 2014 14:02:37 +0100\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -103,7 +103,7 @@ "> > +Example\n" "> > +-------\n" "> > +\n" - "> > +\tcpg_clocks: cpg_clocks@ffc80000 {\n" + "> > +\tcpg_clocks: cpg_clocks at ffc80000 {\n" "> > +\t\tcompatible = \"renesas,r8a7779-cpg-clocks\";\n" "> > +\t\treg = <0 0xffc80000 0 0x80>;\n" "> \n" @@ -294,7 +294,7 @@ "> > +\n" "> > +\tcpg = kzalloc(sizeof(*cpg), GFP_KERNEL);\n" "> > +\tclks = kzalloc(CPG_NUM_CLOCKS * sizeof(*clks), GFP_KERNEL);\n" - "> > +\tif (cpg = NULL || clks = NULL) {\n" + "> > +\tif (cpg == NULL || clks == NULL) {\n" "> > +\t\t/* We're leaking memory on purpose, there's no point in cleaning\n" "> > +\t\t * up as the system won't boot anyway.\n" "> > +\t\t */\n" @@ -308,7 +308,7 @@ "> > +\tcpg->data.clk_num = num_clks;\n" "> > +\n" "> > +\tcpg->reg = of_iomap(np, 0);\n" - "> > +\tif (WARN_ON(cpg->reg = NULL))\n" + "> > +\tif (WARN_ON(cpg->reg == NULL))\n" "> > +\t\treturn;\n" "\n" "As the driver doesn't access any of the CPG registers this could even be \n" @@ -380,4 +380,4 @@ "\n" Laurent Pinchart -2f9f4ba7f45e92dd17385cd2c1e84ac729083ba1ac70bc14bce892abb3a69d67 +99b4964ad7036d10909482f34aca8d99cbf7a3ddade1ca99128f221e7adcb0ec
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.