From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: marcinx.smoczynski@intel.com, bruce.richardson@intel.com,
konstantin.ananyev@intel.com, shahafs@mellanox.com,
gaetan.rivet@6wind.com, adrien.mazarguil@6wind.com,
matan@mellanox.com
Subject: Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD
Date: Fri, 10 May 2019 20:23:54 +0200 [thread overview]
Message-ID: <2604468.nBFxeWxGDx@xps> (raw)
In-Reply-To: <9076832.UKkv39EgZr@xps>
re-send with fixed Cc
10/05/2019 20:17, Thomas Monjalon:
> 10/05/2019 19:14, Smoczynski, MarcinX:
> > To summarize we have different visibility sets for Linux and BSD when using
> > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can
> > either remove problematic XOPEN macros from mk/meson rules (drivers/net/failsafe,
> > drivers/net/mlx4, drivers/net/mlx5)
>
> What is the consequence of removing these macros in mlx and failsafe PMDs?
>
> > or add explicit -D__BSD_VISIBLE when
> > building for BSD. I think also that defining _GNU_SOURCE for BSD builds makes no
> > sense although it does not cause any problems.
> >
> > I have checked that removing those problematic macros solves build problems on
> > FreeBSD12 and does not break on Ubuntu 18.04.
next prev parent reply other threads:[~2019-05-10 18:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 17:14 [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD Smoczynski, MarcinX
2019-05-10 18:17 ` Thomas Monjalon
2019-05-10 18:23 ` Thomas Monjalon [this message]
2019-05-13 9:51 ` Smoczynski, MarcinX
2019-05-13 10:25 ` Adrien Mazarguil
2019-05-13 10:49 ` Ananyev, Konstantin
2019-05-13 13:14 ` Adrien Mazarguil
2019-05-13 16:24 ` Ananyev, Konstantin
2019-05-14 8:58 ` Smoczynski, MarcinX
2019-05-14 9:16 ` Adrien Mazarguil
2019-05-14 10:29 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2604468.nBFxeWxGDx@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=konstantin.ananyev@intel.com \
--cc=marcinx.smoczynski@intel.com \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.