From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Thu, 7 Dec 2017 08:29:01 -0500 (EST)
Subject: [Cluster-devel] [PATCH 4/8] mkfs.gfs2: Set the rg_skip field in
 new	rgrps
In-Reply-To: <20171207115339.3797-5-anprice@redhat.com>
References: <20171207115339.3797-1-anprice@redhat.com>
	<20171207115339.3797-5-anprice@redhat.com>
Message-ID: <260744929.39449540.1512653341360.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

----- Original Message -----
| This field is the difference between the block address of a rgrp and the
| next one. Includes a test to check the rg_skip field against the rindex.
| 
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---
(snip)
| @@ -615,6 +616,9 @@ lgfs2_rgrp_t lgfs2_rgrps_append(lgfs2_rgrps_t rgs, struct
| gfs2_rindex *entry)
|  	rg->rg.rg_header.mh_type = GFS2_METATYPE_RG;
|  	rg->rg.rg_header.mh_format = GFS2_FORMAT_RG;
|  	rg->rg.rg_free = rg->ri.ri_data;
| +#ifdef GFS2_HAS_RG_SKIP
| +	rg->rg.rg_skip = rg_skip;
| +#endif

We may still want to initialize the value of rg_skip if the #ifdef is false.

The rest looked good.

Bob Peterson