Re: [PATCH v8 00/47] TruFlow update for Thor2

[Thomas Monjalon <thomas@monjalon.net>]

08/11/2024 03:14, Ajit Khaparde:
> On Thu, Nov 7, 2024 at 6:05 PM Sriharsha Basavapatna
> <sriharsha.basavapatna@broadcom.com> wrote:
> > > v7->v8:
> > > Changed logging macros CFA_TCAM_MGR_TRACE()->PMD_DRV_LOG_LINE()
> > > Fixed the following checkpatch warnings:
> > >   Writing to stdout or stderr
> > >   Using __atomic_xxx/__ATOMIC_XXX built-ins,
> > >         prefer rte_atomic_xxx/rte_memory_order_xxx
> > > Added Fixes: tag and Cc: stable@dpdk.org for some patches
> > >
> >
> > There are a couple of patches with warnings about "Prefer
> > RTE_LOG_LINE" and "Do not use variadic argument pack in macros".
> > We haven't fixed these, since it involves a lot of changes. We will
> > fix them in a separate clean-up patch after this patchset is merged.

log and variadic are OK to be cleaned later.
But I cannot merge with SPDX issues, rte_flow doc not updated, __builtin functions.

> Apart from this, I have addressed the spelling errors,
> errors in meson, updates to the rte_flow items and actions list
> while merging.
> 
> Patchset rebased on dpdk main tree and applied to
> dpdk-next-net-brcm main and for-next-net branch.
> Please apply.

I still see these errors from next-net-brcm/for-next-net:

SPDX tag missing in 38 files

rte_flow doc out of sync for bnxt
        item geneve
        item vxlan_gpe
        action set_ipv6_dst
        action set_ipv6_src
        action set_ttl

Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE

Using __builtin helpers, prefer EAL macros

Do not use variadic argument pack in macros

Error: Incorrect indent at drivers/net/bnxt/tf_core/v3/meson.build
Error: Missing trailing "," in list at drivers/net/bnxt/tf_core/v3/meson.build:33
Error parsing drivers/net/bnxt/hcapi/cfa_v3/meson.build, got some tabulation
Error: Incorrect indent at drivers/net/bnxt/hcapi/cfa_v3/meson.build
Error parsing drivers/net/bnxt/tf_ulp/meson.build, got some tabulation
Error parsing drivers/net/bnxt/tf_ulp/generic_templates/meson.build, got some tabulation

+drivers/net/bnxt/tf_core/v3/tfc_global_id.c: duplicated include: tfc.h
+drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c: duplicated include: bnxt.h
+drivers/net/bnxt/tf_core/v3/tfc_tcam.c: duplicated include: tfc.h

Is it candidate for Cc: stable@dpdk.org backport?
        net/bnxt: fix issue reading sff8436 sfp eeproms
        net/bnxt: tf_ulp: fixed parent child db counters

Contributor name/email mismatch with .mailmap: 
        Peter Morrow <peter@graphiant.com> is unknown in .mailmap
        Vasuthevan Maheswaran <vasuthevan.maheswaran@broadcom.com> is unknown in .mailmap

'resoure' may be misspelled - perhaps 'resource'?
'Recrod' may be misspelled - perhaps 'Record'?
'adn' may be misspelled - perhaps 'and'?
'decorder' may be misspelled - perhaps 'decoder'?
'retreved' may be misspelled - perhaps 'retrieved'?
'Foward' may be misspelled - perhaps 'Forward'?
'modfication' may be misspelled - perhaps 'modification'?
'pupose' may be misspelled - perhaps 'purpose'?
'inluding' may be misspelled - perhaps 'including'?
'explicity' may be misspelled - perhaps 'explicitly'?
'Conifiguration' may be misspelled - perhaps 'Configuration'?
'wit' may be misspelled - perhaps 'with'?
'spefific' may be misspelled - perhaps 'specific'?
'thorugh' may be misspelled - perhaps 'through'?
'hve' may be misspelled - perhaps 'have'?
'localy' may be misspelled - perhaps 'locally'?
'singe' may be misspelled - perhaps 'single'?
'faeture' may be misspelled - perhaps 'feature'?
'paranthesis' may be misspelled - perhaps 'parenthesis'?
'firmwware' may be misspelled - perhaps 'firmware'?