All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: "oraveeps@pm.me" <oraveeps@pm.me>,
	Chih Kai Hsu <hsu.chih.kai@realtek.com>
Cc: "javen_xu@realsil.com.cn" <javen_xu@realsil.com.cn>,
	"mail@birger-koblitz.de" <mail@birger-koblitz.de>,
	"linux-firmware@kernel.org" <linux-firmware@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: rtl_nic: request for rtl8159-1.fw (RTL8159 PHY firmware)
Date: Wed, 18 Nov 2026 06:58:09 +0000	[thread overview]
Message-ID: <260ddf2d9e344d2dae559a1c3909e92f@realtek.com> (raw)
In-Reply-To: <tPt9UQiUVXfE9K4MHjmkc9no1QcTNZAOhmdtvdx_yaIkVdWoxkTdDFxCdBK5RU5nKHrKGy99QZq_rUsF0mWO9bfPZmS_8tjbbrNl2B5mNwg=@pm.me>

oraveeps@pm.me <oraveeps@pm.me>
> Sent: Monday, November 16, 2026 6:38 PM
[...]
> Hi Hayes,
> 
> Thanks for the files (rtl8157-1 and rtl8159-1, v1 11/13/26). Mainline
> r8152 (v7.2.4 here, same code in v7.4-rc1) rejects them at the first
> block: rtl8152_is_fw_mac_ok() has no RTL_VER_16/RTL_VER_17 case for
> RTL_FW_PLA or RTL_FW_USB, so rtl8152_check_firmware() fails with
> "check USB firmware failed".
> 
> An rtl8159-1.fw with only your PHY_SPEED_UP block (checksum
> recomputed) loads with the in-tree driver on 7.2.4 and links my RTL8159
> adapter (0bda:815a) at 10G.
> 
> The series "r8152: split RTL_VER_17 into QFN68 and QFN100 package
> variants" (v8) does not change rtl8152_is_fw_mac_ok() either, so the
> full files are rejected with it applied too. Is a driver change for the
> PLA/USB blocks planned? If not, could rtl8159-1.fw carry only the PHY
> block?

Chih-Kai will update the driver.
However, some patches are still pending review,
so we need to wait until they are merged before proceeding.


Best Regards,
Hayes

> Thanks,
> Jonas Autzen
> 
> 
> On Monday, 16 November 2026 at 09:30, Hayes Wang
> <hayeswang@realtek.com> wrote:
> 
> > Hi,
> >
> > Could you please try out the attached files?
> >
> > Best Regards,
> >
> > Hayes
> >
> > > From: oraveeps@pm.me <oraveeps@pm.me>
> > > Sent: Sunday, November 8, 2026 5:42 PM
> > > To: Hayes Wang <hayeswang@realtek.com>
> > > Cc: javen_xu@realsil.com.cn; mail@birger-koblitz.de;
> linux-firmware@kernel.org; netdev@vger.kernel.org
> > > Subject: rtl_nic: request for rtl8159-1.fw (RTL8159 PHY firmware)
> > >
> > > External mail : This email originated from outside the organization. Do not
> reply, click links, or open attachments unless you recognize the sender and
> know the content is safe.
> > >
> > > Hi Hayes,
> > >
> > > Since commit a51e171e176c ("r8152: Add firmware upload capability for
> > >
> > > RTL8157/RTL8159"), mainline r8152 requests rtl_nic/rtl8159-1.fw for the
> > >
> > > RTL8159 PHY. Without it the link stays at 5 Gbit/s, and linux-firmware
> > >
> > > has no rtl8159-1.fw yet (nor rtl8157-1.fw).
> > >
> > > I run three RTL8159 adapters (USB ID 0bda:815a) on kernel 7.2.4. They
> > >
> > > reach 10 Gbit/s only with Realtek's out-of-tree r8152 v2.22.1, which
> > >
> > > carries the PHY patch inside the driver. With rtl8159-1.fw in
> > >
> > > linux-firmware, the in-tree driver could do the same and users could
> > >
> > > drop the out-of-tree module.
> > >
> > > Could Realtek submit rtl8159-1.fw, and rtl8157-1.fw if there is one, to
> > >
> > > linux-firmware? I am happy to test a candidate file on these adapters.
> > >
> > > Thanks,
> > >
> > > Jonas Autzen

      parent reply	other threads:[~2026-11-18  6:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  9:41 rtl_nic: request for rtl8159-1.fw (RTL8159 PHY firmware) oraveeps
     [not found] ` <7b6ef8fb2c14485380c90f1f7521ea9b@realtek.com>
2026-11-16 10:37   ` oraveeps
2026-11-16 12:07     ` Birger Koblitz
2026-11-16 15:33       ` oraveeps
2026-11-18  6:58     ` Hayes Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=260ddf2d9e344d2dae559a1c3909e92f@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=hsu.chih.kai@realtek.com \
    --cc=javen_xu@realsil.com.cn \
    --cc=linux-firmware@kernel.org \
    --cc=mail@birger-koblitz.de \
    --cc=netdev@vger.kernel.org \
    --cc=oraveeps@pm.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.