From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792424460; b=Sj6O1Ez5eUHCIck/s53DQCQAa7jms9d0LHubZO1g+wHtTw/p+VA43PDcYQPA6lskJG5/ wcqMP09Hrhg7217PUVET7j4tBYBAs40xwF3lhQi21/QVvpjA2oAivmh+ZZgrzMXbTk5qq raOhiFAKqUTeumhl924hY0eXf6CKw0cqPZnIYVwm3Jk3koQ0bmext8AT83x7/12LpVy95 90n2cxo2y+R5/YknTTdU2NTTa5wS12eALUe1/qPxDfdp6YuKgtSIbvKLLYkwDCM5qkawA a4McgwjjsFsUpCprGc9CTxQYExb32R2YYKdhHFIVxGB6ZA3o78nrhedR64fPoDPcgJA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792424460; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Organization:From:In-Reply-To: References:To:Cc:Subject:MIME-Version:Date:Message-ID:X-Scanned-By: X-Mimecast-MFC-PROC-ID:X-Mimecast-Originator:Content-Type:Content-ID; bh=yziQSCxdp7ps3qMUbiHDhum2cL5ZNoqGNN2WDzodKHc=; b=i1mg7CUOSCh653GL4TwdZMw5OkLQACMguAD7zi3Z25PBAiq1scRYEKmxUOsbynmTTy2F RiT6G9KjD+XeNVEzII1mZzIV9Ds4WsbomF1FCTRu8e+w70zI5zkUZfZFOnIpDxkhQm5CS vv0/arV+unojE0U82TUHiI6olWYb8B0zhEGXAg60Sipe/T0FFPxiJZ/jq1FNcWkp0Ttoz fjNqyzN4CYMBTNZHWOEOUJEkRXs2/T+EKHZ5+SpVjZHeKGxWZ2/0PWpMqWo9cQPd/i5xT 2BLfWfL98KkvXXgKwGV/Z+KH0aR2ojxAMzneDjEu74I3EUfrEyQ5MUcUb/sx/CjoTpg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AoRZlj5R; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 344B46086074 for ; Mon, 19 Oct 2026 15:41:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 344B46086074 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AoRZlj5R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792424459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yziQSCxdp7ps3qMUbiHDhum2cL5ZNoqGNN2WDzodKHc=; b=AoRZlj5RbYlvfGpAUhlQddkctqYO+7WlZwgaCtLQJ0is/AI641pXL3K3LZzKLX1E/uyxCl abln3Cfhzy2WbZTmvKFrWhZezZirR5BevQDndx+7IMEHQkbX1Jv3ToQ+22V42pqcUgIOaj fePTOV+//N1NU3QXgMkbGM8EZFphATA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-SMnf-nxSMaCCQN_0EplOqg-1; Mon, 19 Oct 2026 15:40:55 +0000 X-MC-Unique: SMnf-nxSMaCCQN_0EplOqg-1 X-Mimecast-MFC-AGG-ID: SMnf-nxSMaCCQN_0EplOqg_1792424453 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB9731955F03; Mon, 19 Oct 2026 15:40:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.48.11]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A3A501803A44; Mon, 19 Oct 2026 15:40:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20261019142516.300040-6-jarkko@kernel.org> References: <20261019142516.300040-6-jarkko@kernel.org> <20261019142516.300040-1-jarkko@kernel.org> To: Jarkko Sakkinen Cc: dhowells@redhat.com, keyrings@vger.kernel.org, Eric Biggers , stable@vger.kernel.org, Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , linux-security-module@vger.kernel.org (open list:SECURITY SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: Re: [RFC PATCH 5/8] KEYS: Prevent overflow of quota in key_alloc() X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Mon, 19 Oct 2026 16:40:47 +0100 Message-ID: <2610080.1792424447@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: EK61Z0F55uPxIlX4DYPN2mT7vxZjzCKQg5J-ZfH-izA_1792424453 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-ID: <2610079.1792424447.1@warthog.procyon.org.uk> Jarkko Sakkinen wrote: > - if (desclen > U16_MAX) This should also be KEY_MAX_DESC_SIZE. > + if (desclen > U16_MAX || type->def_datalen > INT_MAX - desclen - 1) That looks awkward, but I can see why you did it. Reviewed-by: David Howells