Re: [PATCH v2] net/mlx5: fix connection tracking state item validation

[Thomas Monjalon <thomas@monjalon.net>]

13/08/2025 16:16, Dariusz Sosnowski:
> Hi,
> 
> Thank you for the patch. Please see comments inline.
> 
> On Tue, Aug 12, 2025 at 08:46:30AM -0400, Khadem Ullah wrote:
> > This patch validate a connection tracking state when matching
> > 'conntrack is' in rte_flow rules. Since conntrack item flags
> > is a bitmap, then any combination of RTE_FLOW_CONNTRACK_PKT_STATE_*
> > flags is a valid value to match on.
> > 
> > This patch validate the CT state item.
> > Fixes: aca19061e4b9 ('net/mlx5: validate connection tracking item')
> 
> When used locally ./devtool/checkpatches.sh reports the following:
> 
> 	WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: aca19061e4b9 ("net/mlx5: validate connection tracking item")'
> 	#12:
> 	Fixes: aca19061e4b9 ('net/mlx5: validate connection tracking item')
> 
> but it's not reported in "ci/checkpatch" job in Patchwork.
> This check was added in Linux 6.1: https://github.com/torvalds/linux/commit/bd17e036b495bebbf07a5fc814c868e30e1dc131
> so it appears that checkpatch.pl version used in CI is older than that.
> Locally, I have a version from Linux 6.16.
> 
> Ali, Thomas, David: What do you think about updating the version of
> checkpatch.pl used in community CI?

I've updated the checkpatch script used in the CI.
It's the latest version from Linux minus few non-relevant checks.