From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Andy Walls <awalls@md.metrocast.net>,
linux-media@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption
Date: Mon, 29 Oct 2012 16:03:04 +0000 [thread overview]
Message-ID: <2614655.PC7gBWDYxH@f17simon> (raw)
In-Reply-To: <20121029134445.1f58657e@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Monday 29 October 2012 13:44:45 Mauro Carvalho Chehab wrote:
> Thanks for digging into it and getting more data. Do you know if this change
> it also needed with USB devices that do DMA (isoc and/or bulk)? Or the USB
> core already handles that?
>
I'm not a huge expert - the linux-pm list (cc'd) will have people around who
know more.
If I've understood correctly, though, the USB core should take care of pm_qos
requests if they're needed for the hardware; remember that if the HCD has
enough buffering, there's no need for a pm_qos request. It's only needed for
devices like the SAA7134 where the buffer is small (1K split into pieces)
compared to the sample data rate (27 megabytes/second raw video).
For the benefit of the linux-pm list; this all starts with me providing a
patch to have the saa7134 driver request reduced cpu_dma_latency when
streaming, as I've seen buffer exhaustion. We've got far enough to know that
the value I chose was wrong for the saa7134, but Mauro also wants guidance on
whether USB devices (not host controllers) also need to request reduced
latency.
--
Simon Farnsworth
Software Engineer
ONELAN Ltd
http://www.onelan.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-10-29 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 11:50 [PATCH] saa7134: Add pm_qos_request to fix video corruption Simon Farnsworth
2012-10-29 11:25 ` Simon Farnsworth
2012-10-29 11:58 ` Mauro Carvalho Chehab
2012-10-29 13:02 ` Simon Farnsworth
2012-10-29 13:32 ` Andy Walls
2012-10-29 14:11 ` Simon Farnsworth
2012-10-29 15:44 ` Mauro Carvalho Chehab
2012-10-29 16:03 ` Simon Farnsworth [this message]
2012-10-30 15:11 ` Alan Stern
2012-10-30 15:11 ` Alan Stern
2012-12-04 17:22 ` Mauro Carvalho Chehab
2012-10-29 14:27 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2614655.PC7gBWDYxH@f17simon \
--to=simon.farnsworth@onelan.co.uk \
--cc=awalls@md.metrocast.net \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.