From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04902C3F2D1 for ; Wed, 4 Mar 2020 03:53:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D965720842 for ; Wed, 4 Mar 2020 03:53:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D965720842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mikelr.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 64FE06E9A8; Wed, 4 Mar 2020 03:53:50 +0000 (UTC) Received: from yyz.mikelr.com (unknown [IPv6:2602:ffb6:2:0:f816:3eff:fe0d:377b]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8C676E9A8 for ; Wed, 4 Mar 2020 03:20:48 +0000 (UTC) Received: from glidewell.localnet (198-84-194-208.cpe.teksavvy.com [198.84.194.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by yyz.mikelr.com (Postfix) with ESMTPSA id 6DF123CFC8; Tue, 3 Mar 2020 22:20:46 -0500 (EST) From: Mikel Rychliski To: Bjorn Helgaas Subject: Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom Date: Tue, 03 Mar 2020 22:20:45 -0500 Message-ID: <2616060.jBR9Tdob1i@glidewell> In-Reply-To: <20200303143827.GA78253@google.com> References: <20200303143827.GA78253@google.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 04 Mar 2020 03:53:49 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "David \(ChunMing\) Zhou" , linux-pci@vger.kernel.org, Matthew Garrett , amd-gfx@lists.freedesktop.org, Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote: > Cosmetics: > > s/ioremap/ioremap()/ (also in commit log) > s/phys_to_virt/phys_to_virt()/ (also in commit log) > s/pci_platform_rom/pci_platform_rom()/ (commit log) > s/rom/ROM/ > This changes the interface of pci_platform_rom() (the caller is now > responsible for doing an iounmap()). That should be mentioned in the > function comment, and I think the subsequent patches should be > squashed into this one so the interface change and the caller changes > are done simultaneously. > > Also, it looks like nvbios_platform.init() (platform_init()) needs a > similar change? Hi Bjorn, Thank you for your comments. I'll make the suggested changes, add an iounmap() in the nouveau usage, and provide a new two-patch series. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8585CC3F2CE for ; Wed, 4 Mar 2020 03:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58B1D20842 for ; Wed, 4 Mar 2020 03:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387469AbgCDDUs (ORCPT ); Tue, 3 Mar 2020 22:20:48 -0500 Received: from yyz.mikelr.com ([170.75.163.43]:57158 "EHLO yyz.mikelr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387400AbgCDDUs (ORCPT ); Tue, 3 Mar 2020 22:20:48 -0500 Received: from glidewell.localnet (198-84-194-208.cpe.teksavvy.com [198.84.194.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by yyz.mikelr.com (Postfix) with ESMTPSA id 6DF123CFC8; Tue, 3 Mar 2020 22:20:46 -0500 (EST) From: Mikel Rychliski To: Bjorn Helgaas Cc: amd-gfx@lists.freedesktop.org, linux-pci@vger.kernel.org, Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , Matthew Garrett Subject: Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom Date: Tue, 03 Mar 2020 22:20:45 -0500 Message-ID: <2616060.jBR9Tdob1i@glidewell> In-Reply-To: <20200303143827.GA78253@google.com> References: <20200303143827.GA78253@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote: > Cosmetics: > > s/ioremap/ioremap()/ (also in commit log) > s/phys_to_virt/phys_to_virt()/ (also in commit log) > s/pci_platform_rom/pci_platform_rom()/ (commit log) > s/rom/ROM/ > This changes the interface of pci_platform_rom() (the caller is now > responsible for doing an iounmap()). That should be mentioned in the > function comment, and I think the subsequent patches should be > squashed into this one so the interface change and the caller changes > are done simultaneously. > > Also, it looks like nvbios_platform.init() (platform_init()) needs a > similar change? Hi Bjorn, Thank you for your comments. I'll make the suggested changes, add an iounmap() in the nouveau usage, and provide a new two-patch series.