Re: [PATCH v2] drm/xe/tests: Move shrink test out of xe_bo

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Wed, 2024-12-18 at 15:14 +0100, Nirmoy Das wrote:
> The subtest typically has an execution time long enough to motivate a
> separate test so that it can be easily excluded if needed.
> 
> v2: reword commit message(Thomas)
> 
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


> ---
>  drivers/gpu/drm/xe/tests/xe_bo.c            | 16 ++++++++++++++--
>  drivers/gpu/drm/xe/tests/xe_live_test_mod.c |  2 ++
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_bo.c
> b/drivers/gpu/drm/xe/tests/xe_bo.c
> index c9ec7a313c6b..405ff904153e 100644
> --- a/drivers/gpu/drm/xe/tests/xe_bo.c
> +++ b/drivers/gpu/drm/xe/tests/xe_bo.c
> @@ -606,8 +606,6 @@ static void xe_bo_shrink_kunit(struct kunit
> *test)
>  static struct kunit_case xe_bo_tests[] = {
>  	KUNIT_CASE_PARAM(xe_ccs_migrate_kunit,
> xe_pci_live_device_gen_param),
>  	KUNIT_CASE_PARAM(xe_bo_evict_kunit,
> xe_pci_live_device_gen_param),
> -	KUNIT_CASE_PARAM_ATTR(xe_bo_shrink_kunit,
> xe_pci_live_device_gen_param,
> -			      {.speed = KUNIT_SPEED_SLOW}),
>  	{}
>  };
>  
> @@ -618,3 +616,17 @@ struct kunit_suite xe_bo_test_suite = {
>  	.init = xe_kunit_helper_xe_device_live_test_init,
>  };
>  EXPORT_SYMBOL_IF_KUNIT(xe_bo_test_suite);
> +
> +static struct kunit_case xe_bo_shrink_test[] = {
> +	KUNIT_CASE_PARAM_ATTR(xe_bo_shrink_kunit,
> xe_pci_live_device_gen_param,
> +			      {.speed = KUNIT_SPEED_SLOW}),
> +	{}
> +};
> +
> +VISIBLE_IF_KUNIT
> +struct kunit_suite xe_bo_shrink_test_suite = {
> +	.name = "xe_bo_shrink",
> +	.test_cases = xe_bo_shrink_test,
> +	.init = xe_kunit_helper_xe_device_live_test_init,
> +};
> +EXPORT_SYMBOL_IF_KUNIT(xe_bo_shrink_test_suite);
> diff --git a/drivers/gpu/drm/xe/tests/xe_live_test_mod.c
> b/drivers/gpu/drm/xe/tests/xe_live_test_mod.c
> index 0d36ab864ec0..81277c77016d 100644
> --- a/drivers/gpu/drm/xe/tests/xe_live_test_mod.c
> +++ b/drivers/gpu/drm/xe/tests/xe_live_test_mod.c
> @@ -6,11 +6,13 @@
>  #include <kunit/test.h>
>  
>  extern struct kunit_suite xe_bo_test_suite;
> +extern struct kunit_suite xe_bo_shrink_test_suite;
>  extern struct kunit_suite xe_dma_buf_test_suite;
>  extern struct kunit_suite xe_migrate_test_suite;
>  extern struct kunit_suite xe_mocs_test_suite;
>  
>  kunit_test_suite(xe_bo_test_suite);
> +kunit_test_suite(xe_bo_shrink_test_suite);
>  kunit_test_suite(xe_dma_buf_test_suite);
>  kunit_test_suite(xe_migrate_test_suite);
>  kunit_test_suite(xe_mocs_test_suite);