From: Florian Fainelli <florian@openwrt.org>
To: linux-mips@linux-mips.org, balbi@ti.com
Cc: ralf@linux-mips.org, jogo@openwrt.org, mbizon@freebox.fr,
cernekee@gmail.com, linux-usb@vger.kernel.org,
stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
blogic@openwrt.org
Subject: Re: [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private register
Date: Mon, 28 Jan 2013 22:17:15 +0100 [thread overview]
Message-ID: <2622165.icySTsWGzL@bender> (raw)
In-Reply-To: <20130128204114.GA5509@arwen.pp.htv.fi>
On Monday 28 January 2013 22:41:14 Felipe Balbi wrote:
> Hi,
>
> On Mon, Jan 28, 2013 at 08:06:21PM +0100, Florian Fainelli wrote:
> > diff --git a/drivers/usb/gadget/bcm63xx_udc.c b/drivers/usb/gadget/bcm63xx_udc.c
> > index ad17533..af450c4 100644
> > --- a/drivers/usb/gadget/bcm63xx_udc.c
> > +++ b/drivers/usb/gadget/bcm63xx_udc.c
> > @@ -41,6 +41,7 @@
> > #include <bcm63xx_dev_usb_usbd.h>
> > #include <bcm63xx_io.h>
> > #include <bcm63xx_regs.h>
> > +#include <bcm63xx_usb_priv.h>
>
> actually, I want to see this arch dependency vanish. The whole
> "phy_mode" stuff should be a PHY driver, care to implement this properly
> using the PHY layer ?
Ok, but then I won't be able to use the generic OHCI and EHCI platform drivers
because they are not yet aware of clocks, PHY slave device etc... For now I
would like to stick with that since this is also very BCM63xx centric.
Would that be ok with you?
--
Florian
next prev parent reply other threads:[~2013-01-28 21:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 19:06 [PATCH 00/13] MIPS: BCM63XX: support for OHCI and EHCI integrated controllers Florian Fainelli
2013-01-28 19:06 ` [PATCH 01/13] MIPS: BCM63XX: add USB host clock enable delay Florian Fainelli
2013-01-28 19:06 ` [PATCH 02/13] MIPS: BCM63XX: add USB device clock enable delay to clock code Florian Fainelli
2013-01-28 19:06 ` [PATCH 03/13] MIPS: BCM63XX: move code touching the USB private register Florian Fainelli
2013-01-28 20:41 ` Felipe Balbi
2013-01-28 20:41 ` Felipe Balbi
2013-01-28 21:17 ` Florian Fainelli [this message]
2013-01-29 7:37 ` Felipe Balbi
2013-01-29 7:37 ` Felipe Balbi
2013-01-28 19:06 ` [PATCH 04/13] MIPS: BCM63XX: add OHCI/EHCI configuration bits to common USB code Florian Fainelli
2013-01-28 19:06 ` [PATCH 05/13] MIPS: BCM63XX: introduce BCM63XX_OHCI configuration symbol Florian Fainelli
2013-01-28 19:06 ` [PATCH 06/13] MIPS: BCM63XX: add support for the on-chip OHCI controller Florian Fainelli
2013-01-28 19:06 ` [PATCH 07/13] MIPS: BCM63XX: register OHCI controller if board enables it Florian Fainelli
2013-01-28 19:06 ` [PATCH 08/13] MIPS: BCM63XX: introduce BCM63XX_EHCI configuration symbol Florian Fainelli
2013-01-28 19:29 ` David Daney
2013-01-28 19:57 ` Florian Fainelli
2013-01-28 20:15 ` Alan Stern
2013-01-28 20:15 ` Alan Stern
2013-01-28 19:06 ` [PATCH 09/13] MIPS: BCM63XX: add support for the on-chip EHCI controller Florian Fainelli
2013-01-28 19:06 ` [PATCH 10/13] MIPS: BCM63XX: register EHCI controller if board enables it Florian Fainelli
2013-01-28 19:06 ` [PATCH 11/13] USB: EHCI: add ignore_oc flag to disable overcurrent checking Florian Fainelli
2013-01-28 20:08 ` Alan Stern
2013-01-28 20:08 ` Alan Stern
2013-01-28 20:58 ` Florian Fainelli
2013-01-28 19:06 ` [PATCH 12/13] MIPS: BCM63XX: EHCI controller does not support overcurrent Florian Fainelli
2013-01-28 19:06 ` [PATCH 13/13] MIPS: BCM63XX: update defconfig Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2622165.icySTsWGzL@bender \
--to=florian@openwrt.org \
--cc=balbi@ti.com \
--cc=blogic@openwrt.org \
--cc=cernekee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.