From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1U8ow1-0002eN-8I for mharc-grub-devel@gnu.org; Fri, 22 Feb 2013 04:28:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8ovz-0002eB-1T for grub-devel@gnu.org; Fri, 22 Feb 2013 04:28:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8ovv-00082P-Th for grub-devel@gnu.org; Fri, 22 Feb 2013 04:28:50 -0500 Received: from collab.rosalab.ru ([217.199.216.181]:49217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8ovv-000824-Mt for grub-devel@gnu.org; Fri, 22 Feb 2013 04:28:47 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id 2A0BD29C316; Fri, 22 Feb 2013 13:28:46 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 19Ku7-h4sXYB; Fri, 22 Feb 2013 13:28:45 +0400 (MSK) Received: from icedphoenix.localnet (unknown [10.168.1.56]) by collab.rosalab.ru (Postfix) with ESMTPSA id 731FF29C293; Fri, 22 Feb 2013 13:28:45 +0400 (MSK) From: Vladimir Testov To: Andrey Borzenkov Subject: [PATCH] fix selected item's height Date: Fri, 22 Feb 2013 13:28:45 +0400 Message-ID: <2625645.NEvtgNsnSc@icedphoenix> User-Agent: KMail/4.9.4 (Linux/3.5.0-23-generic; KDE/4.9.4; x86_64; ; ) In-Reply-To: <20130221215607.59adc7b3@opensuse.site> References: <42509525.u0FQyoZF34@icedphoenix> <20130221215607.59adc7b3@opensuse.site> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart6742507.8V1xRUgUQl" Content-Transfer-Encoding: 7Bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 217.199.216.181 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2013 09:28:52 -0000 This is a multi-part message in MIME format. --nextPart6742507.8V1xRUgUQl Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" > selected item box is not really used to layout items. Only to adjust > where the first item is placed, to allow for full top border to be > displayed. Patch I just sent also adds space for lower border. By the way, your patch is not absolutely correct. We should correct selected item's height. The formula you have presented do not consider the fact that selected item's height is decreased by 1. Patch included. -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru --nextPart6742507.8V1xRUgUQl Content-Disposition: attachment; filename="grub2-fix-selected-item-height.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="grub2-fix-selected-item-height.patch" diff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-tmp/grub-core/gfxmenu/gui_list.c --- grub-2.00/grub-core/gfxmenu/gui_list.c 2011-12-14 14:36:07.000000000 +0400 +++ grub-tmp/grub-core/gfxmenu/gui_list.c 2013-02-22 13:24:01.496967086 +0400 @@ -252,7 +252,7 @@ int cwidth = oviewport.width - 2 * boxpad - 2; if (selbox->get_border_width) cwidth -= selbox->get_border_width (selbox); - selbox->set_content_size (selbox, cwidth, item_height - 1); + selbox->set_content_size (selbox, cwidth, item_height); selbox->draw (selbox, 0, item_top - sel_toppad); } --nextPart6742507.8V1xRUgUQl--