All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: gregkh@linuxfoundation.org, Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: commit c7e88ecbe328 ("staging: r8188eu: remove rtw_buf_free() function")
Date: Tue, 03 Aug 2021 14:23:25 +0200	[thread overview]
Message-ID: <26260563.P9vmH3Ooqy@localhost.localdomain> (raw)
In-Reply-To: <20210803072129.GA1422@agape.jhs>

On Tuesday, August 3, 2021 9:21:30 AM CEST Fabio Aiuto wrote:
> 
> Do you have any idea of what happened? This
> topic could give us all deeper understanding
> of kernel memory management.
> 
Hi Fabio,

I've just briefly looked at that c7e88ecbe328. I have no time to dig it deeper 
but at a first look it seems that the following line is the culprit:

kfree(&pmlmepriv->assoc_req);

It should be:

kfree(pmlmepriv->assoc_req);

The second line frees the memory location whose address is saved in assoc_rec; 
the first line instead frees assoc_req itself.

Regards,

Fabio 




  reply	other threads:[~2021-08-03 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  7:21 commit c7e88ecbe328 ("staging: r8188eu: remove rtw_buf_free() function") Fabio Aiuto
2021-08-03 12:23 ` Fabio M. De Francesco [this message]
2021-08-03 12:39   ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26260563.P9vmH3Ooqy@localhost.localdomain \
    --to=fmdefrancesco@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.