From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33328C433F5 for ; Tue, 3 May 2022 17:38:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA5F911211E; Tue, 3 May 2022 17:38:17 +0000 (UTC) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26B1A112092; Tue, 3 May 2022 17:02:59 +0000 (UTC) Received: by mail-ed1-x531.google.com with SMTP id a1so20585806edt.3; Tue, 03 May 2022 10:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=HaGnyx7pBoke+0aSLZ+0Cl9i2Z3rtc277xsE07lgnGx2lIPgKNR+/cHf1BHMJd+tWY xLxDVjfXM0LpLkK6W47aSnLqvt4qcngT1GxJ9qnMFGWSSL68ZSpCJur0Qp+flnz9TG9V 8iSPz7fXNdaty2uNHB4TWoNsqJrz0v03bb5rxLo5UKkUbCeepA8IK+d4f511ABt2QcWd ZpC42ODRQgilCYofK3JnmcBW/XdrLxgbLavwJlZDJe38uRpGjKQRfb1xNvaHi8pmKFwS 8RYFI+ibpzWIAh8L22MX0fUODrvS/rlJYgws3AcC0d8zDmBJEhPw91evXIyGqHtd9B1w 9Xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=WyqOks+4qIIq2QxZFHB4sZFBCsHY8qjb6z4diu97ccDgFpMnfjCIZjkoda0b+cSMxa UTA4NXWaiN+kfQwQWOyFEv8eaOGOIzhF6LYN3tNBIq+9vYZeaiQZqQ6bxdeFg1SWO4G1 4eJNk1grTvf0epclWb3PGQZ3Ci/8xmREHms9gzK/hOVjsraiCH1J6W07SCTXjO94jjoH Dn6Or68hJsvHCtMsFb1mo3QjW8iHswrvlmLTDErIdfa7bBlj4JVZ57fD1jUvf6FF02VB Q8Rq/9PRJ/q3SV0CrdmLAjTtgXQQb0VHApXbrKVgsK8AL+8/hz63OR76unHNLAbXnlbB 4F0w== X-Gm-Message-State: AOAM530BFHH+k3r1oXK8xf/lGzoL7bxB6/H8S/k4QUUnTDd4XYTN2bi2 1KmIvS8e9V6opryEk8siOYI= X-Google-Smtp-Source: ABdhPJwhqGbymFuBTyPLL+yyc+nnpILMy/ni7d7XOhYbnZCBoZ0oS8dRxaoc/0h9PTlfn8SevSJmlw== X-Received: by 2002:a05:6402:1941:b0:413:2822:9c8 with SMTP id f1-20020a056402194100b00413282209c8mr18716302edz.13.1651597377548; Tue, 03 May 2022 10:02:57 -0700 (PDT) Received: from kista.localnet (cpe1-3-76.cable.triera.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id q8-20020aa7cc08000000b0042617ba637esm8000905edt.8.2022.05.03.10.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 10:02:56 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: Re: [PATCH v3 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Date: Tue, 03 May 2022 19:02:54 +0200 Message-ID: <2626921.mvXUDI8C0e@kista> In-Reply-To: <20220503071540.471667-3-javierm@redhat.com> References: <20220503071540.471667-1-javierm@redhat.com> <20220503071540.471667-3-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Mailman-Approved-At: Tue, 03 May 2022 17:38:16 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Daniel Vetter , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, amd-gfx@lists.freedesktop.org, Thomas Zimmermann , spice-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Laurent Pinchart Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Dne torek, 03. maj 2022 ob 09:15:39 CEST je Javier Martinez Canillas napisal(a): > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is only used by a few drivers, and to allow > drivers to use it for passing other configurations when registering the > fbdev, rename @preferred_bpp to @options and make it a multi-field param. > > The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers > for computing options bitfield values and getting the values respectively > > For now, only the DRM_FB_BPP option exists but other options can be added. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Drop the preferred_bpp local variable (Laurent Pinchart). > - Add a const qualifier to options parameter (Laurent Pinchart). > > Changes in v2: > - Rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() and make more clear in > the kernel-doc what this macro does (Laurent Pinchart). > - Fix some kernel-doc issues I didn't notice in v1. > - Add Reviewed-by tags from Thomas and Laurent. > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/ast/ast_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 26 ++++++++++++------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > drivers/gpu/drm/mcde/mcde_drv.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/sti/sti_drv.c | 2 +- > drivers/gpu/drm/stm/drv.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- For sun4i: Acked-by: Jernej Skrabec Best regard, Jernej > drivers/gpu/drm/tidss/tidss_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/tiny/arcpgu.c | 2 +- > drivers/gpu/drm/tiny/bochs.c | 2 +- > drivers/gpu/drm/tve200/tve200_drv.c | 2 +- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- > include/drm/drm_fb_helper.h | 14 +++++++++- > 33 files changed, 64 insertions(+), 42 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6EA9C433EF for ; Tue, 3 May 2022 17:03:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+JlUNxe1jnUKBnZuhiMDkWhU3CGG4jdjdx4Fla/Y4fc=; b=xXUUt+r9688MoK N86+nOSlNTEVSiu6vShYwHQoCoouv2Imi06O9W6E5+ADadfYI2EgcCsGbLNmvSfUAa5Z8bkzowh+q W+gAv/YUa5Bte+RIdpftTgnpGN8XLaPG/qfXGRikOnbIYsFttmgajsMk/FjB42GB1rzMUyZBcljIG E6n5Gob3f58jLkzeTHMFIeJVJCnhwepsuPKng68wubuFUUcfLiBJczYueJxAKEwPX0z3imT+qnUhd J9LtN6Zze8LN0Hk1FauM/QkS6PU+SDMF2Bj5ASupxuvNlsZMsLLWkrNwQaI627uq0dnOT1ICQtCLd OP4/PRV8NZlZioryEP9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlvvV-006sWC-Bl; Tue, 03 May 2022 17:03:05 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlvvS-006sUC-3E; Tue, 03 May 2022 17:03:03 +0000 Received: by mail-ed1-x52f.google.com with SMTP id be20so20556852edb.12; Tue, 03 May 2022 10:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=HaGnyx7pBoke+0aSLZ+0Cl9i2Z3rtc277xsE07lgnGx2lIPgKNR+/cHf1BHMJd+tWY xLxDVjfXM0LpLkK6W47aSnLqvt4qcngT1GxJ9qnMFGWSSL68ZSpCJur0Qp+flnz9TG9V 8iSPz7fXNdaty2uNHB4TWoNsqJrz0v03bb5rxLo5UKkUbCeepA8IK+d4f511ABt2QcWd ZpC42ODRQgilCYofK3JnmcBW/XdrLxgbLavwJlZDJe38uRpGjKQRfb1xNvaHi8pmKFwS 8RYFI+ibpzWIAh8L22MX0fUODrvS/rlJYgws3AcC0d8zDmBJEhPw91evXIyGqHtd9B1w 9Xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=BTU26TVDPZPi/oXXGSqCb0aZaH+ertMgYk96CnDBp7ZFjsnjgl1LosBA82hBBhhijo azoSLKo8jxR/XVk/6qvi10lj/L1xCdJ8iQsKJTjqqQWERkLQqgbU/2tVPQENOcgSVzJh Bbi5GpUiNUthjmfxoCYjwrviwy9kFw3X6uPSS1heV6tuEOq184H/SEEtclvUN+T+xJEf aiRCr9oiSIfnNcsMl+nEIJq931CEUlQDNT4sSOQH1MpvdJQJ0J0J7TQ5dFlr/F9N7JV6 BhPH+cdF0hkJUs7YV+LJZ3wcm9kbPDWckrwcseJ1oAQilm+pbsc6jc0x/0wWLwf2pxij 4iOA== X-Gm-Message-State: AOAM5327uEhAnfCqhJ+PG4WoD8t4qYBvtOy6VLOaQCj4UWdp81JiNGW3 a5t8yEywPwYFHuKxvHA3SCg= X-Google-Smtp-Source: ABdhPJwhqGbymFuBTyPLL+yyc+nnpILMy/ni7d7XOhYbnZCBoZ0oS8dRxaoc/0h9PTlfn8SevSJmlw== X-Received: by 2002:a05:6402:1941:b0:413:2822:9c8 with SMTP id f1-20020a056402194100b00413282209c8mr18716302edz.13.1651597377548; Tue, 03 May 2022 10:02:57 -0700 (PDT) Received: from kista.localnet (cpe1-3-76.cable.triera.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id q8-20020aa7cc08000000b0042617ba637esm8000905edt.8.2022.05.03.10.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 10:02:56 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Javier Martinez Canillas Cc: Daniel Vetter , Thomas Zimmermann , Laurent Pinchart , Javier Martinez Canillas , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Date: Tue, 03 May 2022 19:02:54 +0200 Message-ID: <2626921.mvXUDI8C0e@kista> In-Reply-To: <20220503071540.471667-3-javierm@redhat.com> References: <20220503071540.471667-1-javierm@redhat.com> <20220503071540.471667-3-javierm@redhat.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_100302_185354_C47522D1 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Dne torek, 03. maj 2022 ob 09:15:39 CEST je Javier Martinez Canillas napisal(a): > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is only used by a few drivers, and to allow > drivers to use it for passing other configurations when registering the > fbdev, rename @preferred_bpp to @options and make it a multi-field param. > > The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers > for computing options bitfield values and getting the values respectively > > For now, only the DRM_FB_BPP option exists but other options can be added. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Drop the preferred_bpp local variable (Laurent Pinchart). > - Add a const qualifier to options parameter (Laurent Pinchart). > > Changes in v2: > - Rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() and make more clear in > the kernel-doc what this macro does (Laurent Pinchart). > - Fix some kernel-doc issues I didn't notice in v1. > - Add Reviewed-by tags from Thomas and Laurent. > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/ast/ast_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 26 ++++++++++++------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > drivers/gpu/drm/mcde/mcde_drv.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/sti/sti_drv.c | 2 +- > drivers/gpu/drm/stm/drv.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- For sun4i: Acked-by: Jernej Skrabec Best regard, Jernej > drivers/gpu/drm/tidss/tidss_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/tiny/arcpgu.c | 2 +- > drivers/gpu/drm/tiny/bochs.c | 2 +- > drivers/gpu/drm/tve200/tve200_drv.c | 2 +- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- > include/drm/drm_fb_helper.h | 14 +++++++++- > 33 files changed, 64 insertions(+), 42 deletions(-) _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DCA7C433FE for ; Tue, 3 May 2022 17:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240021AbiECRGc (ORCPT ); Tue, 3 May 2022 13:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240012AbiECRGb (ORCPT ); Tue, 3 May 2022 13:06:31 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1668530F42; Tue, 3 May 2022 10:02:59 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id b24so20568077edu.10; Tue, 03 May 2022 10:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=HaGnyx7pBoke+0aSLZ+0Cl9i2Z3rtc277xsE07lgnGx2lIPgKNR+/cHf1BHMJd+tWY xLxDVjfXM0LpLkK6W47aSnLqvt4qcngT1GxJ9qnMFGWSSL68ZSpCJur0Qp+flnz9TG9V 8iSPz7fXNdaty2uNHB4TWoNsqJrz0v03bb5rxLo5UKkUbCeepA8IK+d4f511ABt2QcWd ZpC42ODRQgilCYofK3JnmcBW/XdrLxgbLavwJlZDJe38uRpGjKQRfb1xNvaHi8pmKFwS 8RYFI+ibpzWIAh8L22MX0fUODrvS/rlJYgws3AcC0d8zDmBJEhPw91evXIyGqHtd9B1w 9Xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=im+01IOU4Zoy13pHmsTejb3PMVCiXvIelSdvFm7ZuPdaApVanG/iC7B5SyButNzh88 MmkjbG7NCIs9itc0Zv/QaCWOfvkmeHMaVyZ4d110cjTn1f8vOS8I/CqRYS1r84q4XiQ6 ogmIkWFjwiX5rFwsEx3RReBqKuwOA9DcbFgNLsnihu60fPj4rGiLMEZufbHyCzS6m7tc NAd2OYYWBXTdT0YGlZKAz/s/SKdzNszQ7m6UzNZaEI3cgosU6to6Sd4aSweRXYVekDm6 vu7Y13ecVaHQ1I2CMhr5EB0/Bsfzgom0QMKZpMIeAsQdvOXO9IfvEXaU6MtDPmsDbCdh lFgQ== X-Gm-Message-State: AOAM5309Om5VFGj4a+z32x3cDRW4j58y9elGbwyHdKnw2sgqUPjXP5a/ 8qejceBq9hrDU5OLOG79eX5lijrt784= X-Google-Smtp-Source: ABdhPJwhqGbymFuBTyPLL+yyc+nnpILMy/ni7d7XOhYbnZCBoZ0oS8dRxaoc/0h9PTlfn8SevSJmlw== X-Received: by 2002:a05:6402:1941:b0:413:2822:9c8 with SMTP id f1-20020a056402194100b00413282209c8mr18716302edz.13.1651597377548; Tue, 03 May 2022 10:02:57 -0700 (PDT) Received: from kista.localnet (cpe1-3-76.cable.triera.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id q8-20020aa7cc08000000b0042617ba637esm8000905edt.8.2022.05.03.10.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 10:02:56 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Javier Martinez Canillas Cc: Daniel Vetter , Thomas Zimmermann , Laurent Pinchart , Javier Martinez Canillas , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Date: Tue, 03 May 2022 19:02:54 +0200 Message-ID: <2626921.mvXUDI8C0e@kista> In-Reply-To: <20220503071540.471667-3-javierm@redhat.com> References: <20220503071540.471667-1-javierm@redhat.com> <20220503071540.471667-3-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Dne torek, 03. maj 2022 ob 09:15:39 CEST je Javier Martinez Canillas napisal(a): > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is only used by a few drivers, and to allow > drivers to use it for passing other configurations when registering the > fbdev, rename @preferred_bpp to @options and make it a multi-field param. > > The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers > for computing options bitfield values and getting the values respectively > > For now, only the DRM_FB_BPP option exists but other options can be added. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Drop the preferred_bpp local variable (Laurent Pinchart). > - Add a const qualifier to options parameter (Laurent Pinchart). > > Changes in v2: > - Rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() and make more clear in > the kernel-doc what this macro does (Laurent Pinchart). > - Fix some kernel-doc issues I didn't notice in v1. > - Add Reviewed-by tags from Thomas and Laurent. > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/ast/ast_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 26 ++++++++++++------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > drivers/gpu/drm/mcde/mcde_drv.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/sti/sti_drv.c | 2 +- > drivers/gpu/drm/stm/drv.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- For sun4i: Acked-by: Jernej Skrabec Best regard, Jernej > drivers/gpu/drm/tidss/tidss_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/tiny/arcpgu.c | 2 +- > drivers/gpu/drm/tiny/bochs.c | 2 +- > drivers/gpu/drm/tve200/tve200_drv.c | 2 +- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- > include/drm/drm_fb_helper.h | 14 +++++++++- > 33 files changed, 64 insertions(+), 42 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B1A2C433F5 for ; Tue, 3 May 2022 17:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KNI7tr1v45s5y00918/780sSZNVCNKNA1QBvg13yA08=; b=bLQNzivVlK1leR Tqg8cemWmS47fq2DkAjnUe95tx42htCecZX0FsthhQpzI7ifGOwcKGIr1rmCVwZqEbk12k4oteRJ9 bnOKTtDTBXyzFnOEXntKpRCIoECydhnPl52q61IOVoyHdJPF8nUJk5SBsnLotx9jz3yCwbxyv2x31 GU9E6EO4O4NlmWhvNPCfUh7sIYeHvoTY6VFth8tR9scpsb9MCgHO8QJXLJ0NQ7UuL8ap2XgfQXydv 7dOkOb5/2bcn92de+6ylmgqO+h7tL+RNTdz6u/ly1PkMuGc+Ou0P3V34uV61To+aJKsZyIIxJUu3T DZ5XnEhjpMGS83O9zpfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlvve-006sZd-J6; Tue, 03 May 2022 17:03:14 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlvvS-006sUC-3E; Tue, 03 May 2022 17:03:03 +0000 Received: by mail-ed1-x52f.google.com with SMTP id be20so20556852edb.12; Tue, 03 May 2022 10:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=HaGnyx7pBoke+0aSLZ+0Cl9i2Z3rtc277xsE07lgnGx2lIPgKNR+/cHf1BHMJd+tWY xLxDVjfXM0LpLkK6W47aSnLqvt4qcngT1GxJ9qnMFGWSSL68ZSpCJur0Qp+flnz9TG9V 8iSPz7fXNdaty2uNHB4TWoNsqJrz0v03bb5rxLo5UKkUbCeepA8IK+d4f511ABt2QcWd ZpC42ODRQgilCYofK3JnmcBW/XdrLxgbLavwJlZDJe38uRpGjKQRfb1xNvaHi8pmKFwS 8RYFI+ibpzWIAh8L22MX0fUODrvS/rlJYgws3AcC0d8zDmBJEhPw91evXIyGqHtd9B1w 9Xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=BTU26TVDPZPi/oXXGSqCb0aZaH+ertMgYk96CnDBp7ZFjsnjgl1LosBA82hBBhhijo azoSLKo8jxR/XVk/6qvi10lj/L1xCdJ8iQsKJTjqqQWERkLQqgbU/2tVPQENOcgSVzJh Bbi5GpUiNUthjmfxoCYjwrviwy9kFw3X6uPSS1heV6tuEOq184H/SEEtclvUN+T+xJEf aiRCr9oiSIfnNcsMl+nEIJq931CEUlQDNT4sSOQH1MpvdJQJ0J0J7TQ5dFlr/F9N7JV6 BhPH+cdF0hkJUs7YV+LJZ3wcm9kbPDWckrwcseJ1oAQilm+pbsc6jc0x/0wWLwf2pxij 4iOA== X-Gm-Message-State: AOAM5327uEhAnfCqhJ+PG4WoD8t4qYBvtOy6VLOaQCj4UWdp81JiNGW3 a5t8yEywPwYFHuKxvHA3SCg= X-Google-Smtp-Source: ABdhPJwhqGbymFuBTyPLL+yyc+nnpILMy/ni7d7XOhYbnZCBoZ0oS8dRxaoc/0h9PTlfn8SevSJmlw== X-Received: by 2002:a05:6402:1941:b0:413:2822:9c8 with SMTP id f1-20020a056402194100b00413282209c8mr18716302edz.13.1651597377548; Tue, 03 May 2022 10:02:57 -0700 (PDT) Received: from kista.localnet (cpe1-3-76.cable.triera.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id q8-20020aa7cc08000000b0042617ba637esm8000905edt.8.2022.05.03.10.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 10:02:56 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Javier Martinez Canillas Cc: Daniel Vetter , Thomas Zimmermann , Laurent Pinchart , Javier Martinez Canillas , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Date: Tue, 03 May 2022 19:02:54 +0200 Message-ID: <2626921.mvXUDI8C0e@kista> In-Reply-To: <20220503071540.471667-3-javierm@redhat.com> References: <20220503071540.471667-1-javierm@redhat.com> <20220503071540.471667-3-javierm@redhat.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_100302_185354_C47522D1 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Dne torek, 03. maj 2022 ob 09:15:39 CEST je Javier Martinez Canillas napisal(a): > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is only used by a few drivers, and to allow > drivers to use it for passing other configurations when registering the > fbdev, rename @preferred_bpp to @options and make it a multi-field param. > > The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers > for computing options bitfield values and getting the values respectively > > For now, only the DRM_FB_BPP option exists but other options can be added. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Drop the preferred_bpp local variable (Laurent Pinchart). > - Add a const qualifier to options parameter (Laurent Pinchart). > > Changes in v2: > - Rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() and make more clear in > the kernel-doc what this macro does (Laurent Pinchart). > - Fix some kernel-doc issues I didn't notice in v1. > - Add Reviewed-by tags from Thomas and Laurent. > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/ast/ast_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 26 ++++++++++++------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > drivers/gpu/drm/mcde/mcde_drv.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/sti/sti_drv.c | 2 +- > drivers/gpu/drm/stm/drv.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- For sun4i: Acked-by: Jernej Skrabec Best regard, Jernej > drivers/gpu/drm/tidss/tidss_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/tiny/arcpgu.c | 2 +- > drivers/gpu/drm/tiny/bochs.c | 2 +- > drivers/gpu/drm/tve200/tve200_drv.c | 2 +- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- > include/drm/drm_fb_helper.h | 14 +++++++++- > 33 files changed, 64 insertions(+), 42 deletions(-) _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D2FDC433F5 for ; Tue, 3 May 2022 17:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=awahOs6JI5dA4iIfz5wA5a6ZQRqy0769xk3zYtKaPkQ=; b=DRXfy4MpX8II6I pl4FjfFrxC5/nMzmeHJS5bDbPjjjrzDqpYWTdtzd1YiJl832LdKOrxT8d2KSO+Sf0/mQjih1YIIMY iFDIB72zTxlrxEQb264UO4cjX07PQdCO86S0Rvx08wRyACXvjuTwXCL27cbb60sqYhzkpf4Q+TlKX c9ZYDINGrQYu1HgGrYJh74LrizPYmJFH+8QbJT7qLQmqpXFGQPKRC7W7modAPRxPF7FBnloISRq0Z itH0+S6259XTQPCXOmcXUfnKr1r6vWQ9a8U2xfmGYCZ96AjHkokjDVfNTCBwsFdelM297VRPPQwwy UvQkAkF33IQCzpZqfZUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlvvW-006sWc-HD; Tue, 03 May 2022 17:03:06 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlvvS-006sUC-3E; Tue, 03 May 2022 17:03:03 +0000 Received: by mail-ed1-x52f.google.com with SMTP id be20so20556852edb.12; Tue, 03 May 2022 10:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=HaGnyx7pBoke+0aSLZ+0Cl9i2Z3rtc277xsE07lgnGx2lIPgKNR+/cHf1BHMJd+tWY xLxDVjfXM0LpLkK6W47aSnLqvt4qcngT1GxJ9qnMFGWSSL68ZSpCJur0Qp+flnz9TG9V 8iSPz7fXNdaty2uNHB4TWoNsqJrz0v03bb5rxLo5UKkUbCeepA8IK+d4f511ABt2QcWd ZpC42ODRQgilCYofK3JnmcBW/XdrLxgbLavwJlZDJe38uRpGjKQRfb1xNvaHi8pmKFwS 8RYFI+ibpzWIAh8L22MX0fUODrvS/rlJYgws3AcC0d8zDmBJEhPw91evXIyGqHtd9B1w 9Xiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0ebsl3t9Q4A5ZhggZdMt0K6huVQ4nPLjVF1HT4eHwHY=; b=BTU26TVDPZPi/oXXGSqCb0aZaH+ertMgYk96CnDBp7ZFjsnjgl1LosBA82hBBhhijo azoSLKo8jxR/XVk/6qvi10lj/L1xCdJ8iQsKJTjqqQWERkLQqgbU/2tVPQENOcgSVzJh Bbi5GpUiNUthjmfxoCYjwrviwy9kFw3X6uPSS1heV6tuEOq184H/SEEtclvUN+T+xJEf aiRCr9oiSIfnNcsMl+nEIJq931CEUlQDNT4sSOQH1MpvdJQJ0J0J7TQ5dFlr/F9N7JV6 BhPH+cdF0hkJUs7YV+LJZ3wcm9kbPDWckrwcseJ1oAQilm+pbsc6jc0x/0wWLwf2pxij 4iOA== X-Gm-Message-State: AOAM5327uEhAnfCqhJ+PG4WoD8t4qYBvtOy6VLOaQCj4UWdp81JiNGW3 a5t8yEywPwYFHuKxvHA3SCg= X-Google-Smtp-Source: ABdhPJwhqGbymFuBTyPLL+yyc+nnpILMy/ni7d7XOhYbnZCBoZ0oS8dRxaoc/0h9PTlfn8SevSJmlw== X-Received: by 2002:a05:6402:1941:b0:413:2822:9c8 with SMTP id f1-20020a056402194100b00413282209c8mr18716302edz.13.1651597377548; Tue, 03 May 2022 10:02:57 -0700 (PDT) Received: from kista.localnet (cpe1-3-76.cable.triera.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id q8-20020aa7cc08000000b0042617ba637esm8000905edt.8.2022.05.03.10.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 10:02:56 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Javier Martinez Canillas Cc: Daniel Vetter , Thomas Zimmermann , Laurent Pinchart , Javier Martinez Canillas , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Date: Tue, 03 May 2022 19:02:54 +0200 Message-ID: <2626921.mvXUDI8C0e@kista> In-Reply-To: <20220503071540.471667-3-javierm@redhat.com> References: <20220503071540.471667-1-javierm@redhat.com> <20220503071540.471667-3-javierm@redhat.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_100302_185354_C47522D1 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 03. maj 2022 ob 09:15:39 CEST je Javier Martinez Canillas napisal(a): > By default the bits per pixel for the emulated framebuffer device is set > to dev->mode_config.preferred_depth, but some devices need another value. > > Since this second parameter is only used by a few drivers, and to allow > drivers to use it for passing other configurations when registering the > fbdev, rename @preferred_bpp to @options and make it a multi-field param. > > The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers > for computing options bitfield values and getting the values respectively > > For now, only the DRM_FB_BPP option exists but other options can be added. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Drop the preferred_bpp local variable (Laurent Pinchart). > - Add a const qualifier to options parameter (Laurent Pinchart). > > Changes in v2: > - Rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() and make more clear in > the kernel-doc what this macro does (Laurent Pinchart). > - Fix some kernel-doc issues I didn't notice in v1. > - Add Reviewed-by tags from Thomas and Laurent. > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +++-- > drivers/gpu/drm/arm/hdlcd_drv.c | 2 +- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/ast/ast_drv.c | 2 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > drivers/gpu/drm/drm_drv.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 26 ++++++++++++------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +- > .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 +- > drivers/gpu/drm/imx/imx-drm-core.c | 2 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > drivers/gpu/drm/mcde/mcde_drv.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/gpu/drm/meson/meson_drv.c | 2 +- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/sti/sti_drv.c | 2 +- > drivers/gpu/drm/stm/drv.c | 2 +- > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +- For sun4i: Acked-by: Jernej Skrabec Best regard, Jernej > drivers/gpu/drm/tidss/tidss_drv.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > drivers/gpu/drm/tiny/arcpgu.c | 2 +- > drivers/gpu/drm/tiny/bochs.c | 2 +- > drivers/gpu/drm/tve200/tve200_drv.c | 2 +- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- > drivers/gpu/drm/vc4/vc4_drv.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 +- > include/drm/drm_fb_helper.h | 14 +++++++++- > 33 files changed, 64 insertions(+), 42 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel