From: Stefan Berger <stefanb@linux.ibm.com>
To: Takashi Iwai <tiwai@suse.de>, Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, Andy Liang <andy.liang@hpe.com>,
jenifer.golmitz@hpe.com
Subject: Re: [PATCH] tpm/eventlog: Use kvmalloc() for event log buffer
Date: Thu, 7 Nov 2024 14:06:52 -0500 [thread overview]
Message-ID: <262eff2e-90c5-45db-81d7-30b1cc217ef4@linux.ibm.com> (raw)
In-Reply-To: <878qtvi5he.wl-tiwai@suse.de>
On 11/7/24 7:38 AM, Takashi Iwai wrote:
> On Thu, 07 Nov 2024 13:17:33 +0100,
> Paul Menzel wrote:
>>
>> Dear Takashi,
>>
>>
>> Thank you for the patch.
>>
>> Am 07.11.24 um 12:18 schrieb Takashi Iwai:
>>> The TPM2 ACPI table may request a large size for the event log, and it
>>> may be over the max size of kmalloc(). When this happens, the driver
>>
>> What is kmalloc()’s maximum size?
>
> 128kB or so, IIRC.
> And according Andy, the table can be over 4MB.
Can you copy the contents of the file on that machine and tell us what
size it has:
cp /sys/kernel/security/tpm0/binary_bios_measurements ./
I wonder what the BIOS on that system writes into this file and wouldn't
exclude a buggy BIOS indicating wrong size and producing a much smaller log.
next prev parent reply other threads:[~2024-11-07 19:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:18 [PATCH] tpm/eventlog: Use kvmalloc() for event log buffer Takashi Iwai
2024-11-07 12:17 ` Paul Menzel
2024-11-07 12:38 ` Takashi Iwai
2024-11-07 19:06 ` Stefan Berger [this message]
2024-11-07 19:31 ` Stefan Berger
2024-11-08 8:24 ` Takashi Iwai
2024-11-08 8:48 ` Liang, Andy (Linux Ecosystem Engineering)
2024-11-08 9:28 ` Takashi Iwai
2024-11-11 8:43 ` Liang, Andy (Linux Ecosystem Engineering)
2024-11-12 17:56 ` Jarkko Sakkinen
2024-11-13 3:00 ` Liang, Andy (Linux Ecosystem Engineering)
2024-11-07 20:42 ` Jarkko Sakkinen
2024-11-08 8:22 ` Takashi Iwai
2024-11-07 20:32 ` Jarkko Sakkinen
2024-11-07 20:44 ` Jarkko Sakkinen
2024-11-08 8:21 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262eff2e-90c5-45db-81d7-30b1cc217ef4@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=andy.liang@hpe.com \
--cc=jarkko@kernel.org \
--cc=jenifer.golmitz@hpe.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.