From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources. Date: Wed, 21 Dec 2016 17:19:29 +0100 Message-ID: <2631459.aun9V5NdHs@xps13> References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <1479931644-78960-1-git-send-email-benjamin.walker@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Shreyansh Jain , Ben Walker Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id B66CA10CAD for ; Wed, 21 Dec 2016 17:19:31 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id a197so152647530wmd.0 for ; Wed, 21 Dec 2016 08:19:31 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-25 14:51, Shreyansh Jain: > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > If resources were mapped prior to probe, unmap them > > if probe fails. > > > > This does not handle the case where the kernel driver was > > forcibly unbound prior to probe. > > > > Signed-off-by: Ben Walker > > Acked-by: Shreyansh Jain The 3 first patches of this series seems good and easy to agree, except some minor nits. Please Ben or Shreyansh, could you respin only them to help make progress before applying a PCI/bus rework from Shreyansh? As soon as one of you shoot a partial v3, I'll apply them. Thanks