diff for duplicates of <26364319.123371368669839202.JavaMail.weblogic@epml12> diff --git a/a/1.txt b/N1/1.txt index 20d82f0..43bf6e7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,25 +1,43 @@ -VHVlc2RheSwgTWF5IDE0LCAyMDEzIDExOjE3IFBNLCBWaWthcyBTYWpqYW4gd3JvdGU6DQo+IA0K -PiBIaSBWaWthcywNCj4gDQo+IE9uIFR1ZXNkYXkgMTQgb2YgTWF5IDIwMTMgMTg6MjU6NTEgVmlr -YXMgU2FqamFuIHdyb3RlOg0KPiA+ICBBZGRzIEdQSU8gcGFyc2luZyBmdW5jdGlvbmFsaXR5IGZv -ciAiTENEIGJhY2tsaWdodCIgYW5kICJMQ0QgZW5hYmxlIg0KPiA+ICBHUElPIHBpbnMgb2YgZXh5 -bm9zIGRwIGNvbnRyb2xsZXIuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWthcyBTYWpqYW4g -PHZpa2FzLnNhamphbkBsaW5hcm8ub3JnPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3ZpZGVvL2V4 -eW5vcy9leHlub3NfZHBfY29yZS5jIHwgICA0NQ0KPiA+ICsrKysrKysrKysrKysrKysrKysrKysr -KysrKysrKysrKyAxIGZpbGUgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+IA0KPiBJ -IGRvbid0IHRoaW5rIHRoYXQgRXh5bm9zIERQIGRyaXZlciBpcyByaWdodCBwbGFjZSBmb3Igc3Vj -aCBjb2RlLiBCYWNrbGlnaHQNCj4gYW5kIExDRCBkcml2ZXJzIGFyZSByZXNwb25zaWJsZSBmb3Ig -YmFja2xpZ2h0IGFuZCBMQ0QgcG93ZXIgY29udHJvbCB1c2luZw0KPiBiYWNrbGlnaHQgYW5kIExD -RCBzdWJzeXN0ZW1zLg0KPiANCj4gSU1ITyB0aGUgY29ycmVjdCBzb2x1dGlvbiB3b3VsZCBiZSB0 -byBlaXRoZXIgZXh0ZW5kIGV4aXN0aW5nIGJhY2tsaWdodC9sY2QNCj4gZHJpdmVycyBmb3VuZCBp -biBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodCB0byBzdXBwb3J0IGRpcmVjdCBHUElPIGNvbnRyb2wg -YW5kDQo+IHBhcnNlIEdQSU8gcGlucyBmcm9tIGRldmljZSB0cmVlIG9yIGNyZWF0ZSBuZXcgZ3Bp -b19ibCBhbmQgZ3Bpb19sY2QgZHJpdmVycy4NCg0KSGkgVmlrYXMgU2FqaWFuLA0KDQpJIGFncmVl -IHdpdGggVG9tYXN6IEZpZ2EncyBvcGluaW9uLg0KQmFja2xpZ2h0L0xDRCBmcmFtZXdvcmsgc2hv -dWxkIGJlIHVzZWQuDQplRFAgcGFuZWwgYmFja2xpZ2h0IG9uIFNNREs1MjEwIGJvYXJkIGNhbiBi -ZSBjb250cm9sbGVkIGJ5IFBXTTsNCnRodXMsIHB3bS1iYWNrbGlnaHQgZHJpdmVyIHNob3VsZCBi -ZSB1c2VkLg0KQWxzbywgZURQIHBhbmVsIHJlc2V0IHBpbiBzaG91bGQgYmUgY29udHJvbGxlZCBi -eSB1c2luZw0KcGxhdGZvcm0tbGNkIGRyaXZlci4NCg0KPiANCj4gQ0NpbmcgUmljaGFyZCwgRmxv -cmlhbiBhbmQgbGludXgtZmJkZXYuDQoNCkFsc28sIEkgaGF2ZSBiZWVuIGRvaW5nIGJhY2tsaWdo -dCByZXZpZXdzIGluc3RlYWQgb2YgUmljaGFyZCwNCnBsZWFzZSBkbyBDQydpbmcgbWUuDQoNCkJl -c3QgcmVnYXJkcywNCkppbmdvbyBIYW4NCg0KPiANCj4gQmVzdCByZWdhcmRzLA0KPiBUb21hc3oN -Cg= +Tuesday, May 14, 2013 11:17 PM, Vikas Sajjan wrote: +> +> Hi Vikas, +> +> On Tuesday 14 of May 2013 18:25:51 Vikas Sajjan wrote: +> > Adds GPIO parsing functionality for "LCD backlight" and "LCD enable" +> > GPIO pins of exynos dp controller. +> > +> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org> +> > --- +> > drivers/video/exynos/exynos_dp_core.c | 45 +> > +++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) +> > +> +> I don't think that Exynos DP driver is right place for such code. Backlight +> and LCD drivers are responsible for backlight and LCD power control using +> backlight and LCD subsystems. +> +> IMHO the correct solution would be to either extend existing backlight/lcd +> drivers found in drivers/video/backlight to support direct GPIO control and +> parse GPIO pins from device tree or create new gpio_bl and gpio_lcd drivers. + +Hi Vikas Sajian, + +I agree with Tomasz Figa's opinion. +Backlight/LCD framework should be used. +eDP panel backlight on SMDK5210 board can be controlled by PWM; +thus, pwm-backlight driver should be used. +Also, eDP panel reset pin should be controlled by using +platform-lcd driver. + +> +> CCing Richard, Florian and linux-fbdev. + +Also, I have been doing backlight reviews instead of Richard, +please do CC'ing me. + +Best regards, +Jingoo Han + +> +> Best regards, +> Tomasz diff --git a/a/content_digest b/N1/content_digest index 9b63896..7c416f9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,6 @@ - "ref\01528008.HgBKZQmFTy@amdc1227\0" "From\0\355\225\234\354\247\204\352\265\254 <jg1.han@samsung.com>\0" "Subject\0Re: [PATCH 1/2] video: exynos_dp: Add parsing of gpios pins to exynos-dp driver\0" - "Date\0Thu, 16 May 2013 02:04:02 +0000\0" + "Date\0Thu, 16 May 2013 02:03:59 +0000 (GMT)\0" "To\0Tomasz Figa <t.figa@samsung.com>" " Vikas Sajjan <vikas.sajjan@linaro.org>\0" "Cc\0\355\225\234\354\247\204\352\265\254 <jg1.han@samsung.com>" @@ -15,30 +14,48 @@ " linux-fbdev@vger.kernel.org <linux-fbdev@vger.kernel.org>\0" "\00:1\0" "b\0" - "VHVlc2RheSwgTWF5IDE0LCAyMDEzIDExOjE3IFBNLCBWaWthcyBTYWpqYW4gd3JvdGU6DQo+IA0K\n" - "PiBIaSBWaWthcywNCj4gDQo+IE9uIFR1ZXNkYXkgMTQgb2YgTWF5IDIwMTMgMTg6MjU6NTEgVmlr\n" - "YXMgU2FqamFuIHdyb3RlOg0KPiA+ICBBZGRzIEdQSU8gcGFyc2luZyBmdW5jdGlvbmFsaXR5IGZv\n" - "ciAiTENEIGJhY2tsaWdodCIgYW5kICJMQ0QgZW5hYmxlIg0KPiA+ICBHUElPIHBpbnMgb2YgZXh5\n" - "bm9zIGRwIGNvbnRyb2xsZXIuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWthcyBTYWpqYW4g\n" - "PHZpa2FzLnNhamphbkBsaW5hcm8ub3JnPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3ZpZGVvL2V4\n" - "eW5vcy9leHlub3NfZHBfY29yZS5jIHwgICA0NQ0KPiA+ICsrKysrKysrKysrKysrKysrKysrKysr\n" - "KysrKysrKysrKyAxIGZpbGUgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+IA0KPiBJ\n" - "IGRvbid0IHRoaW5rIHRoYXQgRXh5bm9zIERQIGRyaXZlciBpcyByaWdodCBwbGFjZSBmb3Igc3Vj\n" - "aCBjb2RlLiBCYWNrbGlnaHQNCj4gYW5kIExDRCBkcml2ZXJzIGFyZSByZXNwb25zaWJsZSBmb3Ig\n" - "YmFja2xpZ2h0IGFuZCBMQ0QgcG93ZXIgY29udHJvbCB1c2luZw0KPiBiYWNrbGlnaHQgYW5kIExD\n" - "RCBzdWJzeXN0ZW1zLg0KPiANCj4gSU1ITyB0aGUgY29ycmVjdCBzb2x1dGlvbiB3b3VsZCBiZSB0\n" - "byBlaXRoZXIgZXh0ZW5kIGV4aXN0aW5nIGJhY2tsaWdodC9sY2QNCj4gZHJpdmVycyBmb3VuZCBp\n" - "biBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodCB0byBzdXBwb3J0IGRpcmVjdCBHUElPIGNvbnRyb2wg\n" - "YW5kDQo+IHBhcnNlIEdQSU8gcGlucyBmcm9tIGRldmljZSB0cmVlIG9yIGNyZWF0ZSBuZXcgZ3Bp\n" - "b19ibCBhbmQgZ3Bpb19sY2QgZHJpdmVycy4NCg0KSGkgVmlrYXMgU2FqaWFuLA0KDQpJIGFncmVl\n" - "IHdpdGggVG9tYXN6IEZpZ2EncyBvcGluaW9uLg0KQmFja2xpZ2h0L0xDRCBmcmFtZXdvcmsgc2hv\n" - "dWxkIGJlIHVzZWQuDQplRFAgcGFuZWwgYmFja2xpZ2h0IG9uIFNNREs1MjEwIGJvYXJkIGNhbiBi\n" - "ZSBjb250cm9sbGVkIGJ5IFBXTTsNCnRodXMsIHB3bS1iYWNrbGlnaHQgZHJpdmVyIHNob3VsZCBi\n" - "ZSB1c2VkLg0KQWxzbywgZURQIHBhbmVsIHJlc2V0IHBpbiBzaG91bGQgYmUgY29udHJvbGxlZCBi\n" - "eSB1c2luZw0KcGxhdGZvcm0tbGNkIGRyaXZlci4NCg0KPiANCj4gQ0NpbmcgUmljaGFyZCwgRmxv\n" - "cmlhbiBhbmQgbGludXgtZmJkZXYuDQoNCkFsc28sIEkgaGF2ZSBiZWVuIGRvaW5nIGJhY2tsaWdo\n" - "dCByZXZpZXdzIGluc3RlYWQgb2YgUmljaGFyZCwNCnBsZWFzZSBkbyBDQydpbmcgbWUuDQoNCkJl\n" - "c3QgcmVnYXJkcywNCkppbmdvbyBIYW4NCg0KPiANCj4gQmVzdCByZWdhcmRzLA0KPiBUb21hc3oN\n" - Cg= + "Tuesday, May 14, 2013 11:17 PM, Vikas Sajjan wrote:\n" + "> \n" + "> Hi Vikas,\n" + "> \n" + "> On Tuesday 14 of May 2013 18:25:51 Vikas Sajjan wrote:\n" + "> > Adds GPIO parsing functionality for \"LCD backlight\" and \"LCD enable\"\n" + "> > GPIO pins of exynos dp controller.\n" + "> >\n" + "> > Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>\n" + "> > ---\n" + "> > drivers/video/exynos/exynos_dp_core.c | 45\n" + "> > +++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)\n" + "> >\n" + "> \n" + "> I don't think that Exynos DP driver is right place for such code. Backlight\n" + "> and LCD drivers are responsible for backlight and LCD power control using\n" + "> backlight and LCD subsystems.\n" + "> \n" + "> IMHO the correct solution would be to either extend existing backlight/lcd\n" + "> drivers found in drivers/video/backlight to support direct GPIO control and\n" + "> parse GPIO pins from device tree or create new gpio_bl and gpio_lcd drivers.\n" + "\n" + "Hi Vikas Sajian,\n" + "\n" + "I agree with Tomasz Figa's opinion.\n" + "Backlight/LCD framework should be used.\n" + "eDP panel backlight on SMDK5210 board can be controlled by PWM;\n" + "thus, pwm-backlight driver should be used.\n" + "Also, eDP panel reset pin should be controlled by using\n" + "platform-lcd driver.\n" + "\n" + "> \n" + "> CCing Richard, Florian and linux-fbdev.\n" + "\n" + "Also, I have been doing backlight reviews instead of Richard,\n" + "please do CC'ing me.\n" + "\n" + "Best regards,\n" + "Jingoo Han\n" + "\n" + "> \n" + "> Best regards,\n" + > Tomasz -95035b2a427166e1ead4cbf0569f95d7f2410032711b8603797ba1dc1aba3575 +db75af44e01a4409ed38af6a28980f402e1eaff4f459688c065c4f0a57217684
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.