All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Marvin Liu <yong.liu@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH] eal: allow both allow and block options coexistence
Date: Fri, 07 Jul 2023 09:12:52 +0200	[thread overview]
Message-ID: <2637257.yKVeVyVuyW@thomas> (raw)
In-Reply-To: <20230707050701.21433-1-yong.liu@intel.com>

07/07/2023 07:07, Marvin Liu:
> Currently, all buses use the same eal allow and block options. Need to
> allow both allow and block options for different buses to coexist.
> It wouldn't be a problem for pci bus if both allow and block options
> were present. When the first option occurs, the scan mode for pci bus is
> set.
> 
> For example:
>   --allow 0000:05:00.0 --block wq0.0
>     only pci device 0000:05:00.0 will be scanned
>     all devices except wq0.0 on dsa bus will be scanned
>   --allow 0000:05:00.0 --block 0000:05:00.1
>     block option will be ignored
>   --block 0000:05:00.1 --allow 0000:05:00.0
>     allow option will be ignored

It is wrong to ignore a user parameter silently.

Also, it would be clearer to use the new devargs syntax
with bus=pci,addr=0000:05:00.0




  reply	other threads:[~2023-07-07  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07  5:07 [PATCH] eal: allow both allow and block options coexistence Marvin Liu
2023-07-07  7:12 ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-19  2:29 Marvin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2637257.yKVeVyVuyW@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.