All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Mark yao <mark.yao@rock-chips.com>
Cc: Mike Turquette <mturquette@linaro.org>,
	linux-kernel@vger.kernel.org, djkurtz@chromium.org,
	dianders@chromium.org, dkl@rock-chips.com,
	eddie.cai@rock-chips.com, xjq@rock-chips.com, kfx@rock-chips.com,
	huangtao@rock-chips.com, zyw@rock-chips.com, yxj@rock-chips.com,
	cym@rock-chips.com, zhengsq@rock-chips.com,
	caesar.wang@rock-chips.com, kever.yang@rock-chips.com
Subject: Re: [PATCH] clk: rockchip: rk3288: fix softreset register count
Date: Fri, 12 Sep 2014 11:56:29 +0200	[thread overview]
Message-ID: <2639561.ZlWoeRoRFp@diego> (raw)
In-Reply-To: <1410513887-17459-1-git-send-email-mark.yao@rock-chips.com>

Hi Mark,

Am Freitag, 12. September 2014, 17:24:46 schrieb Mark yao:
> The rk3288 actually has 12 softresets, so fix the register count.

interesting ... I can see the additional registers in the updated TRM, while 
the old one didn't have them.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


> 
> Signed-off-by: Mark yao <mark.yao@rock-chips.com>
> ---
>  drivers/clk/rockchip/clk-rk3288.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3288.c
> b/drivers/clk/rockchip/clk-rk3288.c index 0d8c6c5..2e1d790 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -711,7 +711,7 @@ static void __init rk3288_clk_init(struct device_node
> *np) rockchip_clk_register_branches(rk3288_clk_branches,
>  				  ARRAY_SIZE(rk3288_clk_branches));
> 
> -	rockchip_register_softrst(np, 9, reg_base + RK3288_SOFTRST_CON(0),
> +	rockchip_register_softrst(np, 12, reg_base + RK3288_SOFTRST_CON(0),
>  				  ROCKCHIP_SOFTRST_HIWORD_MASK);
>  }
>  CLK_OF_DECLARE(rk3288_cru, "rockchip,rk3288-cru", rk3288_clk_init);


  reply	other threads:[~2014-09-12  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12  9:24 [PATCH] clk: rockchip: rk3288: fix softreset register count Mark yao
2014-09-12  9:56 ` Heiko Stübner [this message]
2014-09-25 15:11 ` Doug Anderson
2014-09-25 21:46 ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2639561.ZlWoeRoRFp@diego \
    --to=heiko@sntech.de \
    --cc=caesar.wang@rock-chips.com \
    --cc=cym@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=djkurtz@chromium.org \
    --cc=dkl@rock-chips.com \
    --cc=eddie.cai@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kfx@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.yao@rock-chips.com \
    --cc=mturquette@linaro.org \
    --cc=xjq@rock-chips.com \
    --cc=yxj@rock-chips.com \
    --cc=zhengsq@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.